Bug 1324171 - Use 'Search' as placeholder text instead of as a label in-front of search fields. r?jaws draft
authorJalen Adams <leftysolara@gmail.com>
Thu, 22 Dec 2016 00:10:24 -0500
changeset 452760 ff7f834841e0a01c749f803a485d224c9e37efef
parent 451769 1d0a604b44e28ff354b156106967cdcf02fdce5f
child 540289 7ba0fea54c0491727788a5c23ac2227e6a5bca27
push id39472
push userbmo:leftysolara@gmail.com
push dateThu, 22 Dec 2016 05:15:34 +0000
reviewersjaws
bugs1324171
milestone53.0a1
Bug 1324171 - Use 'Search' as placeholder text instead of as a label in-front of search fields. r?jaws MozReview-Commit-ID: 9EA3JcHpNh1
browser/components/preferences/cookies.xul
browser/locales/en-US/chrome/browser/preferences/cookies.dtd
toolkit/components/passwordmgr/content/passwordManager.xul
toolkit/locales/en-US/chrome/passwordmgr/passwordManager.dtd
--- a/browser/components/preferences/cookies.xul
+++ b/browser/components/preferences/cookies.xul
@@ -30,17 +30,18 @@
     <key key="&focusSearch2.key;" modifiers="accel" oncommand="gCookiesWindow.focusFilterBox();"/>
   </keyset>
 
   <vbox flex="1" class="contentPane largeDialogContainer">
     <hbox align="center">
       <textbox type="search" id="filter" flex="1"
                aria-controls="cookiesList"
                oncommand="gCookiesWindow.filter();"
-               placeholder="Search"/>
+               placeholder="&searchFilter.label;"
+               accesskey="&searchFilter.accesskey;"/>
     </hbox>
     <separator class="thin"/>
     <label control="cookiesList" id="cookiesIntro" value="&cookiesonsystem.label;"/>
     <separator class="thin"/>
     <tree id="cookiesList" flex="1" style="height: 10em;"
           onkeypress="gCookiesWindow.onCookieKeyPress(event)"
           onselect="gCookiesWindow.onCookieSelected();"
           hidecolumnpicker="true" seltype="single">
--- a/browser/locales/en-US/chrome/browser/preferences/cookies.dtd
+++ b/browser/locales/en-US/chrome/browser/preferences/cookies.dtd
@@ -23,13 +23,13 @@
 <!ENTITY     props.expires.label            "Expires:">
 <!ENTITY     props.container.label          "Container:">
 
 <!ENTITY     window.title                   "Cookies">
 <!ENTITY     windowClose.key                "w">
 <!ENTITY     focusSearch1.key               "f">
 <!ENTITY     focusSearch2.key               "k">
 
-<!ENTITY     filter.label                   "Search:">
-<!ENTITY     filter.accesskey               "S">
+<!ENTITY     searchFilter.label             "Search">
+<!ENTITY     searchFilter.accesskey         "S">
 
 <!ENTITY     button.close.label             "Close">
 <!ENTITY     button.close.accesskey         "C">
--- a/toolkit/components/passwordmgr/content/passwordManager.xul
+++ b/toolkit/components/passwordmgr/content/passwordManager.xul
@@ -54,17 +54,18 @@
 
   <!-- saved signons -->
   <vbox id="savedsignons" class="contentPane" flex="1">
     <!-- filter -->
     <hbox align="center">
       <textbox id="filter" flex="1" type="search"
                aria-controls="signonsTree"
                oncommand="FilterPasswords();"
-               placeholder="Search"/>
+               placeholder="&searchFilter.label;"
+               accesskey="&searchFilter.accesskey;"/>
     </hbox>
 
     <label control="signonsTree" id="signonsIntro"/>
     <separator class="thin"/>
     <tree id="signonsTree" flex="1"
           width="750"
           style="height: 20em;"
           onkeypress="HandleSignonKeyPress(event)"
--- a/toolkit/locales/en-US/chrome/passwordmgr/passwordManager.dtd
+++ b/toolkit/locales/en-US/chrome/passwordmgr/passwordManager.dtd
@@ -21,18 +21,18 @@
 <!ENTITY      removeall.accesskey             "A">
 
 <!ENTITY      addLogin.label                  "Add Login">
 <!ENTITY      addLogin.accesskey              "L">
 
 <!ENTITY      import.label                    "Import…">
 <!ENTITY      import.accesskey                "I">
 
-<!ENTITY      filter.label                    "Search:">
-<!ENTITY      filter.accesskey                "S">
+<!ENTITY      searchFilter.label              "Search">
+<!ENTITY      searchFilter.accesskey          "S">
 
 <!ENTITY      windowClose.key                 "w">
 <!ENTITY      focusSearch1.key                "f">
 <!ENTITY      focusSearch2.key                "k">
 
 <!ENTITY      copyPasswordCmd.label           "Copy Password">
 <!ENTITY      copyPasswordCmd.accesskey       "C">