Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value. r?Gijs draft
authorEitan Isaacson <eitan@monotonous.org>
Tue, 20 Dec 2016 11:29:26 -0800
changeset 451693 cfbdf299e6bef6cf7efb46bbc9d4631385c263fa
parent 451111 d4b3146a5567a7ddbcdfa5244945db55616cb8d1
child 540100 7c77103ad2035708d5b61ecb6d51457204875652
push id39259
push userbmo:eitan@monotonous.org
push dateTue, 20 Dec 2016 21:36:24 +0000
reviewersGijs
bugs1324868
milestone53.0a1
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value. r?Gijs MozReview-Commit-ID: D6Vnh5jTsiv
toolkit/components/narrate/NarrateControls.jsm
toolkit/components/telemetry/Histograms.json
--- a/toolkit/components/narrate/NarrateControls.jsm
+++ b/toolkit/components/narrate/NarrateControls.jsm
@@ -187,19 +187,19 @@ NarrateControls.prototype = {
           label: gStrings.GetStringFromName("defaultvoice"),
           value: "automatic",
           selected: selectedVoice == "automatic"
         });
         this.voiceSelect.addOptions(options);
       }
 
       let narrateToggle = win.document.getElementById("narrate-toggle");
-      let histogram =
-        Services.telemetry.getKeyedHistogramById("NARRATE_CONTENT_BY_LANGUAGE");
-      let initial = !!this._voicesInitialized;
+      let histogram = Services.telemetry.getKeyedHistogramById(
+        "NARRATE_CONTENT_BY_LANGUAGE_2");
+      let initial = !this._voicesInitialized;
       this._voicesInitialized = true;
 
       if (initial) {
         histogram.add(language, 0);
       }
 
       if (options.length && narrateToggle.hidden) {
         // About to show for the first time..
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10554,19 +10554,19 @@
     "bug_numbers": [1309442],
     "expires_in_version": "56",
     "keyed": true,
     "kind": "linear",
     "high": 100,
     "n_buckets": 10,
     "description": "Percentage of time taken by phases in expensive content paints."
   },
-  "NARRATE_CONTENT_BY_LANGUAGE": {
+  "NARRATE_CONTENT_BY_LANGUAGE_2": {
     "alert_emails": ["eisaacson@mozilla.com"],
-    "bug_numbers": [1308030],
+    "bug_numbers": [1308030, 1324868],
     "releaseChannelCollection": "opt-out",
     "expires_in_version": "56",
     "kind": "enumerated",
     "keyed": true,
     "n_values": 4,
     "description": "Number of Narrate initialization attempts and successes broken up by content's language (ISO 639-1 code) (0 = initialization attempt, 1 = successfully initialized)"
   },
   "NARRATE_CONTENT_SPEAKTIME_MS": {