Bug 1320992 - Enable next set of findbugs checks. r?maliu draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Mon, 19 Dec 2016 17:03:25 +0100
changeset 451061 5c381e1cfc7180098612c80113fa9ab2e28056a9
parent 450924 863c2b61bd27bb6099104933134d3be7c052551a
child 539914 b8d0880e3b24c6b47040b6ca53888cfa3d7a8ed1
push id39040
push users.kaspari@gmail.com
push dateMon, 19 Dec 2016 16:04:04 +0000
reviewersmaliu
bugs1320992
milestone53.0a1
Bug 1320992 - Enable next set of findbugs checks. r?maliu The linked bugs are fixed and we can enable those checks now. MozReview-Commit-ID: 9UdFH1u9D1I
mobile/android/app/findbugs-exclude.xml
--- a/mobile/android/app/findbugs-exclude.xml
+++ b/mobile/android/app/findbugs-exclude.xml
@@ -4,26 +4,16 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 <FindBugsFilter>
 
   <!-- Bug 1315982 -->
   <Match>
     <Bug pattern="DE_MIGHT_IGNORE" />
   </Match>
 
-  <!-- Bug 1316006 -->
-  <Match>
-    <Bug pattern="DMI_INVOKING_TOSTRING_ON_ARRAY" />
-  </Match>
-
-  <!-- Bug 1316005 -->
-  <Match>
-    <Bug pattern="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS" />
-  </Match>
-
   <!-- Bug 1316008 -->
   <Match>
     <Bug pattern="DM_DEFAULT_ENCODING" />
   </Match>
 
   <!-- Bug 1320298 -->
   <Match>
     <Bug pattern="MS_MUTABLE_ARRAY" />
@@ -39,31 +29,21 @@
     <Bug pattern="UL_UNRELEASED_LOCK" />
   </Match>
 
   <!-- Bug 1316011 -->
   <Match>
     <Bug pattern="VO_VOLATILE_INCREMENT" />
   </Match>
 
-  <!-- Bug 1316012 -->
-  <Match>
-    <Bug pattern="DM_BOXED_PRIMITIVE_FOR_PARSING" />
-  </Match>
-
   <!-- Bug 1316021 -->
   <Match>
     <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
   </Match>
 
-  <!-- Bug 1316023 -->
-  <Match>
-    <Bug pattern="UC_USELESS_CONDITION" />
-  </Match>
-
   <!-- Bug 1320316 -->
   <Match>
     <Bug pattern="DM_BOXED_PRIMITIVE_TOSTRING" />
   </Match>
     <Match>
     <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
   </Match>
     <Match>