Bug 1317089 - Pre: Make MOZ_ANDROID_SHARED_ID mandatory. r=sebastian draft
authorNick Alexander <nalexander@mozilla.com>
Wed, 07 Dec 2016 21:24:12 -0800
changeset 449814 d94b86d99deb8269ee91550dafd1a8241f37eaf3
parent 449813 150da4d0f4407e1980c15ecebd6918e2855a042b
child 539588 163dce055bd619c9507015df7247162b0ee42022
push id38674
push usernalexander@mozilla.com
push dateThu, 15 Dec 2016 04:13:05 +0000
reviewerssebastian
bugs1317089
milestone53.0a1
Bug 1317089 - Pre: Make MOZ_ANDROID_SHARED_ID mandatory. r=sebastian It already is mandatory; the build system will set the ID (based on the package name) if it's not given. MozReview-Commit-ID: 4OLnzLwsHJe
mobile/android/base/AndroidManifest.xml.in
mobile/android/tests/browser/robocop/AndroidManifest.xml.in
--- a/mobile/android/base/AndroidManifest.xml.in
+++ b/mobile/android/base/AndroidManifest.xml.in
@@ -1,19 +1,16 @@
 #filter substitution
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
       package="@ANDROID_PACKAGE_NAME@"
       android:installLocation="auto"
       android:versionCode="@ANDROID_VERSION_CODE@"
       android:versionName="@MOZ_APP_VERSION@"
-#ifdef MOZ_ANDROID_SHARED_ID
-      android:sharedUserId="@MOZ_ANDROID_SHARED_ID@"
-#endif
-      >
+      android:sharedUserId="@MOZ_ANDROID_SHARED_ID@">
     <uses-sdk android:minSdkVersion="@MOZ_ANDROID_MIN_SDK_VERSION@"
 #ifdef MOZ_ANDROID_MAX_SDK_VERSION
               android:maxSdkVersion="@MOZ_ANDROID_MAX_SDK_VERSION@"
 #endif
               android:targetSdkVersion="23"/>
 
 <!-- The bouncer APK and the main APK should define the same set of
      <permission>, <uses-permission>, and <uses-feature> elements.  This reduces
--- a/mobile/android/tests/browser/robocop/AndroidManifest.xml.in
+++ b/mobile/android/tests/browser/robocop/AndroidManifest.xml.in
@@ -1,15 +1,13 @@
 #filter substitution
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="org.mozilla.roboexample.test"
-#ifdef MOZ_ANDROID_SHARED_ID
     android:sharedUserId="@MOZ_ANDROID_SHARED_ID@"
-#endif
     android:versionCode="1"
     android:versionName="1.0" >
 
     <uses-sdk android:minSdkVersion="@MOZ_ANDROID_MIN_SDK_VERSION@"
 #ifdef MOZ_ANDROID_MAX_SDK_VERSION
               android:maxSdkVersion="@MOZ_ANDROID_MAX_SDK_VERSION@"
 #endif
               android:targetSdkVersion="23"/>