Bug 1306329 part C - things that depend on xul should no longer link the XPCOM glue library, r?glandium draft
authorBenjamin Smedberg <benjamin@smedbergs.us>
Tue, 01 Nov 2016 15:14:52 -0400
changeset 449027 df7e7da83e8e50b0e0af6006828183846603f56c
parent 449026 640527597f157210af62a071fb06f16db7679f6c
child 449028 a1199457ceba93c0c86c543e20726864b73298d6
push id38515
push userbsmedberg@mozilla.com
push dateTue, 13 Dec 2016 16:11:41 +0000
reviewersglandium
bugs1306329
milestone53.0a1
Bug 1306329 part C - things that depend on xul should no longer link the XPCOM glue library, r?glandium MozReview-Commit-ID: Hk1rrNONChb
build/gecko_templates.mozbuild
--- a/build/gecko_templates.mozbuild
+++ b/build/gecko_templates.mozbuild
@@ -21,40 +21,38 @@ def GeckoBinary(linkage='dependent', msv
     ought to be linked: 'static' or 'dynamic'.
 
     `mozglue` indicates whether to link against the mozglue library, and if
     so, what linkage to apply. Valid values are None (mozglue not linked),
     'program' (mozglue linked to an executable program), or 'library' (mozglue
     linked to a shared library).
     '''
     if msvcrt == 'dynamic' or CONFIG['OS_ARCH'] != 'WINNT' or CONFIG['MOZ_ASAN']:
-        xpcomglue = 'xpcomglue'
+        pass
     elif msvcrt == 'static':
         USE_STATIC_LIBS = True
-        xpcomglue = 'xpcomglue_staticruntime'
         if not CONFIG['GNU_CC']:
             mozglue = None
             if linkage == 'dependent':
                 USE_LIBS += [
                     'mozalloc_staticruntime',
                 ]
     else:
         error('msvcrt must be "dynamic" or "static"')
 
     if linkage == 'dependent':
         USE_LIBS += [
             'nspr',
-            '%s_s' % xpcomglue,
             'xul',
         ]
     elif linkage == 'standalone':
         DEFINES['XPCOM_GLUE'] = True
 
         USE_LIBS += [
-            xpcomglue,
+            'xpcomglue',
         ]
     elif linkage != None:
         error('`linkage` must be "dependent", "standalone" or None')
 
     if mozglue:
         LDFLAGS += CONFIG['MOZ_GLUE_WRAP_LDFLAGS']
         if mozglue == 'program':
             USE_LIBS += ['mozglue']