Bug 1322606: Don't hide MediaError::message behind a pref. r?ehsan draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 08 Dec 2016 16:31:51 -1000
changeset 449552 06e9e37fe10128e55c5b5479515305c8cd23e00b
parent 449538 5a9f156ce268cdd49dd923696a3a9630026dc42e
child 539521 55e62bb7dc1985f8927759126149d2168432fda4
push id38602
push userbmo:jyavenard@mozilla.com
push dateWed, 14 Dec 2016 11:58:09 +0000
reviewersehsan
bugs1322606
milestone53.0a1
Bug 1322606: Don't hide MediaError::message behind a pref. r?ehsan MozReview-Commit-ID: y2Wbf7amvQ
dom/media/test/test_decode_error.html
dom/webidl/MediaError.webidl
modules/libpref/init/all.js
--- a/dom/media/test/test_decode_error.html
+++ b/dom/media/test/test_decode_error.html
@@ -50,17 +50,16 @@ function startTest(test, token) {
 
   v.src = test.name; // implicitly starts a load.
 }
 
 SimpleTest.waitForExplicitFinish();
 SpecialPowers.pushPrefEnv({
   "set": [
     ["media.cache_size", 40000],
-    ["dom.MediaError.message.enabled", true]
   ]
 }, beginTest);
 function beginTest() {
   manager.runTests(gDecodeErrorTests, startTest);
 }
 </script>
 </pre>
 </body>
--- a/dom/webidl/MediaError.webidl
+++ b/dom/webidl/MediaError.webidl
@@ -15,11 +15,10 @@ interface MediaError {
   // Keep these constants in sync with the ones defined in HTMLMediaElement.h
   const unsigned short MEDIA_ERR_ABORTED = 1;
   const unsigned short MEDIA_ERR_NETWORK = 2;
   const unsigned short MEDIA_ERR_DECODE = 3;
   const unsigned short MEDIA_ERR_SRC_NOT_SUPPORTED = 4;
 
   [Constant]
   readonly attribute unsigned short code;
-  [Pref="dom.MediaError.message.enabled"]
   readonly attribute DOMString message;
 };
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -300,23 +300,16 @@ pref("print.shrink-to-fit.scale-limit-pe
 pref("print.use_simplify_page", false);
 
 // Disable support for MathML
 pref("mathml.disabled",    false);
 
 // Enable scale transform for stretchy MathML operators. See bug 414277.
 pref("mathml.scale_stretchy_operators.enabled", true);
 
-// Disable MediaError.message.
-#ifdef RELEASE_OR_BETA
-pref("dom.MediaError.message.enabled", false);
-#else
-pref("dom.MediaError.message.enabled", true);
-#endif
-
 // Enabled on nightly only until we fix mochitest failures.
 #ifdef NIGHTLY_BUILD
 pref("media.dormant-on-pause-timeout-ms", 5000);
 #else
 pref("media.dormant-on-pause-timeout-ms", -1);
 #endif
 
 // Media cache size in kilobytes