Bug 1322423 about:debugging lacks RTL draft
authorTomer Cohen <tomer@tomercohen.com>
Mon, 19 Dec 2016 18:12:40 +0200
changeset 451068 c0b50725255281e40944a7d20f9595ed1692ed75
parent 449351 d2e057b4ac2d439f38e7866c5db3c49f0573649d
child 451125 e63761293fb7b53b3c01b783d92b46f02bec0334
child 451152 f36a695c0e5e7bda6ce9763f169bedebfacd1a90
push id39045
push userbmo:tomer.moz.bugs@tomercohen.com
push dateMon, 19 Dec 2016 16:15:39 +0000
bugs1322423
milestone53.0a1
Bug 1322423 about:debugging lacks RTL MozReview-Commit-ID: JYdMVscUCoW
devtools/client/aboutdebugging/aboutdebugging.css
devtools/client/aboutdebugging/aboutdebugging.xhtml
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -61,17 +61,17 @@ button {
   min-height: 34px;
   display: flex;
   flex-direction: row;
   align-items: start;
 }
 
 .target-icon {
   height: 24px;
-  margin: 0 5px 0 0;
+  margin-inline-end: 5px;
 }
 
 .target-icon:not([src]) {
   display: none;
 }
 
 .inverted-icons .target-icon {
   filter: invert(30%);
@@ -109,25 +109,26 @@ button {
 .target-detail span {
   /* Truncate items that are too long (e.g. URLs that would break the UI). */
   overflow: hidden;
   white-space: nowrap;
   text-overflow: ellipsis;
 }
 
 .target-detail > :not(:first-child) {
-  margin-left: 8px;
+  margin-inline-start: 8px;
 }
 
 .target-status {
   box-sizing: border-box;
   display: inline-block;
 
   min-width: 50px;
-  margin: 4px 5px 0 0;
+  margin-top: 4px;
+  margin-inline-end: 5px;
   padding: 2px;
 
   border-width: 1px;
   border-style: solid;
 
   font-size: 0.6em;
   text-align: center;
 }
@@ -151,24 +152,25 @@ button {
 .addons-controls {
   display: flex;
   flex-direction: row;
 }
 
 .addons-install-error {
   background-color: #f3b0b0;
   padding: 5px 10px;
-  margin: 5px 4px 5px 0px;
+  margin-top: 5px;
+  margin-inline-end: 4px;
 }
 
 .service-worker-disabled .warning,
 .addons-install-error .warning {
   background-image: url(chrome://devtools/skin/images/alerticon-warning.png);
   background-size: 13px 12px;
-  margin-right: 10px;
+  margin-inline-end: 10px;
   display: inline-block;
   width: 13px;
   height: 12px;
 }
 
 @media (min-resolution: 1.1dppx) {
   .service-worker-disabled .warning,
   .addons-install-error .warning {
--- a/devtools/client/aboutdebugging/aboutdebugging.xhtml
+++ b/devtools/client/aboutdebugging/aboutdebugging.xhtml
@@ -1,22 +1,23 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <!DOCTYPE html [
 <!ENTITY % htmlDTD PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-strict.dtd"> %htmlDTD;
+<!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd"> %globalDTD;
 <!ENTITY % toolboxDTD SYSTEM "chrome://devtools/locale/toolbox.dtd"> %toolboxDTD;
 <!ENTITY % aboutdebuggingDTD SYSTEM "chrome://devtools/locale/aboutdebugging.dtd"> %aboutdebuggingDTD;
 ]>
 
 <html xmlns="http://www.w3.org/1999/xhtml">
   <head>
     <title>&aboutDebugging.fullTitle;</title>
     <link rel="stylesheet" href="chrome://global/skin/in-content/common.css" type="text/css"/>
     <link rel="stylesheet" href="chrome://devtools/content/aboutdebugging/aboutdebugging.css"  type="text/css"/>
     <script type="application/javascript" src="resource://devtools/client/shared/vendor/react.js"></script>
     <script type="application/javascript;version=1.8" src="chrome://devtools/content/aboutdebugging/initializer.js"></script>
   </head>
-  <body id="body">
+  <body id="body" dir="&locale.dir;">
   </body>
 </html>