Bug 902596 RTL Support for about:networking r?jaws draft
authorTomer Cohen <tomer@tomercohen.com>
Wed, 14 Dec 2016 02:19:21 +0200
changeset 449351 d2e057b4ac2d439f38e7866c5db3c49f0573649d
parent 447742 c401d72933641748f3738e90e7bbe539705e2f1c
child 449670 265e1bbed9c5427a45a9edd044f5f48844f72f67
child 451059 cd07becfb6d5c216415a594e4789d10050cca7e2
child 451066 1e9d16720ebb599ae942ce0d6c449a025483c652
child 451068 c0b50725255281e40944a7d20f9595ed1692ed75
push id38548
push userbmo:tomer.moz.bugs@tomercohen.com
push dateWed, 14 Dec 2016 01:32:52 +0000
reviewersjaws
bugs902596
milestone53.0a1
Bug 902596 RTL Support for about:networking r?jaws MozReview-Commit-ID: Fif7yAXfY6Y
toolkit/content/aboutNetworking.xhtml
toolkit/themes/shared/aboutNetworking.css
--- a/toolkit/content/aboutNetworking.xhtml
+++ b/toolkit/content/aboutNetworking.xhtml
@@ -6,17 +6,17 @@
 
 <!DOCTYPE html [
 <!ENTITY % htmlDTD PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-strict.dtd"> %htmlDTD;
 <!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd"> %globalDTD;
 <!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd"> %brandDTD;
 <!ENTITY % networkingDTD SYSTEM "chrome://global/locale/aboutNetworking.dtd"> %networkingDTD;
 ]>
 
-<html xmlns="http://www.w3.org/1999/xhtml">
+<html xmlns="http://www.w3.org/1999/xhtml" dir="&locale.dir;">
     <head>
         <title>&aboutNetworking.title;</title>
         <link rel="stylesheet" href="chrome://mozapps/skin/aboutNetworking.css" type="text/css" />
         <script type="application/javascript;version=1.7" src="chrome://global/content/aboutNetworking.js" />
     </head>
     <body id="body">
         <div id="warning_message" class="warningBackground" hidden="true">
             <div class="container">
--- a/toolkit/themes/shared/aboutNetworking.css
+++ b/toolkit/themes/shared/aboutNetworking.css
@@ -10,17 +10,17 @@ html {
 
 body {
   display: flex;
   align-items: stretch;
   height: 100%;
 }
 
 #sectionTitle {
-  float: left;
+  float: inline-start;
 }
 
 #refreshDiv {
   justify-content: flex-end;
   margin-bottom: 0.5em;
 }
 
 #refreshButton {
@@ -81,16 +81,21 @@ body {
   position: absolute;
   display: block;
   width: 1.6em;
   height: 1.6em;
   background: url("chrome://global/skin/icons/warning.svg") no-repeat left center;
   background-size: 1.6em;
 }
 
+.title:dir(rtl)::before {
+  left: auto;
+  right: -2.3em;
+}
+
 .warningBackground button {
   margin-top: 1em;
   margin-left: 0;
   min-width: 100px;
 }
 
 /** Content area **/