Bug 1291366 - Pre: Don't check against {MIN,MAX}_SDK_VERSION. r=sebastian draft
authorNick Alexander <nalexander@mozilla.com>
Mon, 14 Nov 2016 20:46:31 -0800
changeset 450558 ca7678ac6a96d70ec2da638fe0f8b6132b3c14f1
parent 450557 a8fcf08d2edaec504c73c1eb8f399fbb581123e0
child 450559 1fbd131f1f28dfd67465f7ecda40985abd530ae0
push id38898
push usernalexander@mozilla.com
push dateFri, 16 Dec 2016 23:58:40 +0000
reviewerssebastian
bugs1291366
milestone53.0a1
Bug 1291366 - Pre: Don't check against {MIN,MAX}_SDK_VERSION. r=sebastian This had some value for Fennec when we shipped split APKs. Since we don't, there's little value left; and there's definitely no value for GeckoView, which will only ever ship a single library AAR for all consumers. (That library AAR will have a minimum SDK, but it'll be enforced by the Gradle build system, not by runtime checks.) MozReview-Commit-ID: 3l0jUKdCepS
mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareUtils.java
@@ -77,21 +77,16 @@ public final class HardwareUtils {
     public static int getMemSize() {
         return SysInfo.getMemSize();
     }
 
     /**
      * @return false if the current system is not supported (e.g. APK/system ABI mismatch).
      */
     public static boolean isSupportedSystem() {
-        if (Build.VERSION.SDK_INT < AppConstants.Versions.MIN_SDK_VERSION ||
-            Build.VERSION.SDK_INT > AppConstants.Versions.MAX_SDK_VERSION) {
-            return false;
-        }
-
         // See http://developer.android.com/ndk/guides/abis.html
         boolean isSystemARM = Build.CPU_ABI != null && Build.CPU_ABI.startsWith("arm");
         boolean isSystemX86 = Build.CPU_ABI != null && Build.CPU_ABI.startsWith("x86");
 
         boolean isAppARM = AppConstants.ANDROID_CPU_ARCH.startsWith("arm");
         boolean isAppX86 = AppConstants.ANDROID_CPU_ARCH.startsWith("x86");
 
         // Only reject known incompatible ABIs. Better safe than sorry.