Bug 1321638 - Part 4: Remove last GeckoInterface.getActivity call in geckoview. r=jchen
This API is vestigial.
Sadly we can't remove GeckoInterface.getActivity entirely since there
are still some Fennec consumers that I don't care to unravel just yet.
MozReview-Commit-ID: HX038okB4sR
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/BaseGeckoInterface.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/BaseGeckoInterface.java
@@ -39,17 +39,18 @@ public class BaseGeckoInterface implemen
if (mProfile == null) {
mProfile = GeckoProfile.get(mContext);
}
return mProfile;
}
@Override
public Activity getActivity() {
- return (Activity)mContext;
+ // By default, GeckoView consumers do not have a distinguished current foreground Activity.
+ return null;
}
@Override
public String getDefaultUAString() {
return HardwareUtils.isTablet() ? AppConstants.USER_AGENT_FENNEC_TABLET :
AppConstants.USER_AGENT_FENNEC_MOBILE;
}
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
@@ -831,18 +831,17 @@ public class GeckoAppShell
break;
default:
Log.w(LOGTAG, "Error! Can't disable unknown SENSOR type " + aSensortype);
}
}
@WrapForJNI(calledFrom = "gecko")
private static void moveTaskToBack() {
- if (getGeckoInterface() != null)
- getGeckoInterface().getActivity().moveTaskToBack(true);
+ // This is a vestige, to be removed as full-screen support for GeckoView is implemented.
}
@WrapForJNI(calledFrom = "gecko")
public static void scheduleRestart() {
getGeckoInterface().doRestart();
}
// Creates a homescreen shortcut for a web page.