Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS; r?glandium draft
authorGregory Szorc <gps@mozilla.com>
Fri, 02 Dec 2016 10:10:24 -0800
changeset 447207 9d343e8ae14471e25e0e4b31b3aa1d9443892d06
parent 447079 e756ee86e3ea1225d8cdf38ca0eb8b0ded15dd41
child 538995 a19e77fbc60504bba28ebf59603a851994985306
push id38015
push userbmo:gps@mozilla.com
push dateFri, 02 Dec 2016 23:05:07 +0000
reviewersglandium
bugs1321750
milestone53.0a1
Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS; r?glandium moz.configure only sets the color flags value for the target compiler. If the host compiler is a different version and doesn't support color flags, we may pass unrecognized command line options. Until we have better distinction between host and target compilers throughout the build system, just disable automatic color flags for host invocations. We don't have too many host binaries, so this should have negligible impact. MozReview-Commit-ID: KWTLkKvtwHs
config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -349,18 +349,16 @@ ifeq (,$(filter $(COLOR_CFLAGS:-f%=-fno-
 endif
 endef
 
 color_flags_vars := \
   COMPILE_CFLAGS \
   COMPILE_CXXFLAGS \
   COMPILE_CMFLAGS \
   COMPILE_CMMFLAGS \
-  HOST_CFLAGS \
-  HOST_CXXFLAGS \
   LDFLAGS \
   $(NULL)
 
 ifdef MACH_STDOUT_ISATTY
 ifdef COLOR_CFLAGS
 # TODO Bug 1319166 - iTerm2 interprets some bytes  sequences as a
 # request to show a print dialog. Don't enable color on iTerm2 until
 # a workaround is in place.