Bug 1302470 Part 3: Call the new isRangeVisible function to determine whether or not to draw a highlight rect. r?mikedeboer draft
authorMike de Boer <mdeboer@mozilla.com>
Thu, 10 Nov 2016 09:03:58 -0800
changeset 446635 b5d179ea95f3c266862eb0d238b5ee8de25edd59
parent 446634 ff3a387198a9a3ef80e489f8ff9c52387fc08242
child 446636 5441d62c0960cb1746d7c93935708876def0185f
push id37835
push userbwerth@mozilla.com
push dateThu, 01 Dec 2016 17:09:39 +0000
reviewersmikedeboer
bugs1302470
milestone53.0a1
Bug 1302470 Part 3: Call the new isRangeVisible function to determine whether or not to draw a highlight rect. r?mikedeboer MozReview-Commit-ID: ExO6zdjHGVO
toolkit/modules/FinderHighlighter.jsm
--- a/toolkit/modules/FinderHighlighter.jsm
+++ b/toolkit/modules/FinderHighlighter.jsm
@@ -1134,16 +1134,19 @@ FinderHighlighter.prototype = {
     this._updateRangeOutline(dict);
 
     let allRects = [];
     if (paintContent || dict.modalHighlightAllMask) {
       this._updateDynamicRangesRects(dict);
 
       let DOMRect = window.DOMRect;
       for (let [range, rects] of dict.modalHighlightRectsMap) {
+        if (!this.finder._fastFind.isRangeVisible(range, false))
+          continue;
+
         if (dict.updateAllRanges)
           rects = this._updateRangeRects(range);
 
         // If a geometry change was detected, we bail out right away here, because
         // the current set of ranges has been invalidated.
         if (dict.detectedGeometryChange)
           return;