Bug 1321133. Backout 1285373 because it broke addon-sdk page workers. draft
authorMichael Kaply <mozilla@kaply.com>
Tue, 29 Nov 2016 16:59:53 -0600
changeset 445944 c2331f0c5daf0d3ef2e3205672f38ab1ace07973
parent 445943 539929d75bed01a844f4f59b0052e2db08af2fa8
child 538662 0a093f08cc836ede9b767956a4955dcbed552f2c
push id37654
push usermozilla@kaply.com
push dateWed, 30 Nov 2016 15:39:34 +0000
bugs1321133, 1285373
milestone50.1.0
Bug 1321133. Backout 1285373 because it broke addon-sdk page workers. MozReview-Commit-ID: PETFYk9UfF
addon-sdk/source/lib/sdk/event/chrome.js
--- a/addon-sdk/source/lib/sdk/event/chrome.js
+++ b/addon-sdk/source/lib/sdk/event/chrome.js
@@ -52,14 +52,14 @@ function observe(topic) {
   // observerChannel (since third argument is `true`). There for if it
   // will be GC-ed with all it's event listeners once no other references
   // will be held.
   addObserver(observerChannel, topic, true);
 
   // We need to remove any observer added once the add-on is unloaded;
   // otherwise we'll get a "dead object" exception.
   // See: https://bugzilla.mozilla.org/show_bug.cgi?id=1001833
-  unload(() => removeObserver(observerChannel, topic), { weak: true });
+  unload(() => removeObserver(observerChannel, topic));
 
   return observerChannel;
 }
 
 exports.observe = observe;