Bug 1311251 - null check for mFD before use it. r=mayhemer draft
authorShih-Chiang Chien <schien@mozilla.com>
Tue, 29 Nov 2016 11:37:18 +0800
changeset 458768 8ca9f6a4cce2525b9955e9756acdcc42b07473cd
parent 458767 b079c9833e3ed047e1b984e26b8d62d739baa40b
child 541747 dfc37a91df6f360b92e3cd67ef6d55ad3bcfc2dc
push id41061
push userschien@mozilla.com
push dateWed, 11 Jan 2017 02:04:59 +0000
reviewersmayhemer
bugs1311251
milestone53.0a1
Bug 1311251 - null check for mFD before use it. r=mayhemer MozReview-Commit-ID: 8ygi74Uhtmf
netwerk/base/nsUDPSocket.cpp
--- a/netwerk/base/nsUDPSocket.cpp
+++ b/netwerk/base/nsUDPSocket.cpp
@@ -666,16 +666,20 @@ fail:
 
 NS_IMETHODIMP
 nsUDPSocket::Connect(const NetAddr *aAddr)
 {
   UDPSOCKET_LOG(("nsUDPSocket::Connect [this=%p]\n", this));
 
   NS_ENSURE_ARG(aAddr);
 
+  if (NS_WARN_IF(!mFD)) {
+    return NS_ERROR_NOT_INITIALIZED;
+  }
+
   bool onSTSThread = false;
   mSts->IsOnCurrentThread(&onSTSThread);
   NS_ASSERTION(onSTSThread, "NOT ON STS THREAD");
   if (!onSTSThread) {
     return NS_ERROR_FAILURE;
   }
 
   PRNetAddr prAddr;