Bug 1316545 part 6 - Ignore the implicit conversions from Char16.h as they're intended. r?ehsan draft
authorTing-Yu Chou <janus926@gmail.com>
Fri, 25 Nov 2016 11:22:36 +0800
changeset 443891 f07be88aeb087339f8261d21c2a817dc3b844ce6
parent 443890 954a523364f3c171a018e4db9b4f8c47c391dc7b
child 443892 2ed6cbcaa4fa84b2feb7412e3b1f8b7007404b58
push id37133
push userbmo:janus926@gmail.com
push dateFri, 25 Nov 2016 11:04:17 +0000
reviewersehsan
bugs1316545
milestone53.0a1
Bug 1316545 part 6 - Ignore the implicit conversions from Char16.h as they're intended. r?ehsan MozReview-Commit-ID: 5i4hMUrvEVR
build/clang-plugin/clang-plugin.cpp
--- a/build/clang-plugin/clang-plugin.cpp
+++ b/build/clang-plugin/clang-plugin.cpp
@@ -301,16 +301,21 @@ bool isIgnoredPathForImplicitCtor(const 
         Begin->compare_lower(StringRef("icu")) == 0) {
       return true;
     }
     if (Begin->compare_lower(StringRef("chromium")) == 0) {
       // Ignore security/sandbox/chromium but not ipc/chromium.
       ++Begin;
       return Begin != End && Begin->compare_lower(StringRef("sandbox")) == 0;
     }
+#ifdef _WIN32
+    if (Begin->equals(StringRef("Char16.h"))) {
+      return true;
+    }
+#endif
   }
   return false;
 }
 
 bool isIgnoredPathForImplicitConversion(const Decl *Declaration) {
   Declaration = Declaration->getCanonicalDecl();
   SourceLocation Loc = Declaration->getLocation();
   const SourceManager &SM = Declaration->getASTContext().getSourceManager();
@@ -322,16 +327,21 @@ bool isIgnoredPathForImplicitConversion(
     if (Begin->compare_lower(StringRef("graphite2")) == 0) {
       return true;
     }
     if (Begin->compare_lower(StringRef("chromium")) == 0) {
       // Ignore security/sandbox/chromium but not ipc/chromium.
       ++Begin;
       return Begin != End && Begin->compare_lower(StringRef("sandbox")) == 0;
     }
+#ifdef _WIN32
+    if (Begin->equals(StringRef("Char16.h"))) {
+      return true;
+    }
+#endif
   }
   return false;
 }
 
 bool isIgnoredPathForSprintfLiteral(const CallExpr *Call, const SourceManager &SM) {
   SourceLocation Loc = Call->getLocStart();
   SmallString<1024> FileName = SM.getFilename(Loc);
   llvm::sys::fs::make_absolute(FileName);