MozReview: Review Page Redesign: Update main content area to show full commit message (Bug 1309964). r?glob,smacleod draft
authorDavid Walsh <dwalsh@mozilla.com>
Mon, 28 Nov 2016 05:32:39 -0600
changeset 9984 176c195aaf4b8f6b113246dd02e7bf6ee1bc4c71
parent 9983 646d54730cf8012408c5ce9ea87999887c113b37
child 9985 f9e77dbc3934e265f686c29110b98d3d6765a7f3
push id1403
push userbmo:dwalsh@mozilla.com
push dateTue, 29 Nov 2016 16:23:11 +0000
reviewersglob, smacleod
bugs1309964
MozReview: Review Page Redesign: Update main content area to show full commit message (Bug 1309964). r?glob,smacleod MozReview-Commit-ID: 43uvCI9jYoJ
pylib/mozreview/mozreview/fields.py
pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-reviews.less
pylib/mozreview/mozreview/templates/mozreview/commit-main.html
--- a/pylib/mozreview/mozreview/fields.py
+++ b/pylib/mozreview/mozreview/fields.py
@@ -163,23 +163,28 @@ class CommitDetailField(BaseReviewReques
         last_child_commit_id = commit_id
         if is_parent(self.review_request_details, commit_data=commit_data):
             last_child_commit_data = fetch_commit_data(children_details[-1])
             last_child_commit_id = (
                 last_child_commit_data.extra_data.get(COMMIT_ID_KEY))
 
         pull_text = "hg pull -r %s %s" % (last_child_commit_id, repo_path)
 
+        # Get just the extended commit message details for display
+        commit_message_detail = "\n".join(
+            self.review_request_details.description.splitlines()[1:]).strip()
+
         return get_template('mozreview/commit-main.html').render(Context({
             'review_request_details': self.review_request_details,
             'parent_details': parent_details,
             'user': user,
             'author': author,
             'pull_text': pull_text,
             'import_text': import_text,
+            'commit_message_detail': commit_message_detail,
         }))
 
 
 class CommitAuthorField(CommitDataBackedField):
     """Field for the author of the review request's commit"""
     field_id = AUTHOR_KEY
     label = _("Author")
 
--- a/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-reviews.less
+++ b/pylib/mozreview/mozreview/static/mozreview/css/mozilla-theme-reviews.less
@@ -40,16 +40,23 @@
 
   .review-request-meta {
     color: #777;
     text-align: center;
     line-height: 1.6;
     font-size: 110%;
   }
 
+  .review-request-details {
+    margin: 20px auto 0 auto;
+    font-family: inherit;
+    color: inherit;
+    text-align: left;
+  }
+
   .status {
     margin-bottom: 10px;
   }
 
   #review-request-inputs {
     margin-top: 20px;
 
     input {
--- a/pylib/mozreview/mozreview/templates/mozreview/commit-main.html
+++ b/pylib/mozreview/mozreview/templates/mozreview/commit-main.html
@@ -42,9 +42,13 @@
     <input type="text" value="{{ pull_text }}" onclick="this.select();" readonly>
   {% endif %}
 
   {% if import_text %}
     <input type="text" value="{{ import_text }}" onclick="this.select();" readonly>
   {% endif %}
 </div>
 
+{% if commit_message_detail %}
+  <pre class="review-request-details">{{ commit_message_detail }}</pre>
+{% endif %}
+
 </div>