Bug 1318803: provide reason for IPC_FAIL in case of STUN filtering. r?jdm draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Fri, 18 Nov 2016 16:25:34 -0800
changeset 441526 51a9177a4d564c41aef82b9a76585fe5ac4939f8
parent 440454 05e5b12f41df270b31955ff7e6d09245c1f83a7a
child 441592 ac0d6f6f42ee20eb39484d636c784501d1e6f295
push id36438
push userdrno@ohlmeier.org
push dateSat, 19 Nov 2016 00:25:52 +0000
reviewersjdm
bugs1318803
milestone53.0a1
Bug 1318803: provide reason for IPC_FAIL in case of STUN filtering. r?jdm MozReview-Commit-ID: JTClCwfLB0f
dom/network/UDPSocketParent.cpp
--- a/dom/network/UDPSocketParent.cpp
+++ b/dom/network/UDPSocketParent.cpp
@@ -347,17 +347,17 @@ UDPSocketParent::RecvOutgoingData(const 
     bool allowed;
     const InfallibleTArray<uint8_t>& data(aData.get_ArrayOfuint8_t());
     rv = mFilter->FilterPacket(&aAddr.get_NetAddr(), data.Elements(),
                                data.Length(), nsISocketFilter::SF_OUTGOING,
                                &allowed);
 
     // Sending unallowed data, kill content.
     if (NS_WARN_IF(NS_FAILED(rv)) || !allowed) {
-      return IPC_FAIL_NO_REASON(this);
+      return IPC_FAIL(this, "Content tried to send non STUN packet");
     }
   }
 
   switch(aData.type()) {
     case UDPData::TArrayOfuint8_t:
       Send(aData.get_ArrayOfuint8_t(), aAddr);
       break;
     case UDPData::TInputStreamParams: