Bug 1318282 - Use C++11's override and remove virtual where applicable in storage/. draft
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Thu, 17 Nov 2016 12:36:25 +0200
changeset 442292 dac1e557952933084aacfa0c5c5e22408616542f
parent 442291 d9c61c4cb10644a6f70127ff60ea4685db0f5f41
child 537766 7f6537bd329a60fbccabd15b4e83cecc5990f4bd
push id36664
push userbmo:bpostelnicu@mozilla.com
push dateTue, 22 Nov 2016 08:18:07 +0000
bugs1318282
milestone53.0a1
Bug 1318282 - Use C++11's override and remove virtual where applicable in storage/. MozReview-Commit-ID: AXchuOpF65X
storage/mozStorageConnection.cpp
storage/test/test_AsXXX_helpers.cpp
--- a/storage/mozStorageConnection.cpp
+++ b/storage/mozStorageConnection.cpp
@@ -410,17 +410,17 @@ public:
       nsCOMPtr<nsIThread> thread;
       (void)NS_GetMainThread(getter_AddRefs(thread));
       (void)thread->Dispatch(mCallbackEvent, NS_DISPATCH_NORMAL);
     }
 
     return NS_OK;
   }
 
-  ~AsyncCloseConnection() {
+  ~AsyncCloseConnection() override {
     NS_ReleaseOnMainThread(mConnection.forget());
     NS_ReleaseOnMainThread(mCallbackEvent.forget());
   }
 private:
   RefPtr<Connection> mConnection;
   sqlite3 *mNativeConnection;
   nsCOMPtr<nsIRunnable> mCallbackEvent;
   nsCOMPtr<nsIThread> mAsyncExecutionThread;
@@ -468,17 +468,17 @@ public:
 private:
   nsresult Dispatch(nsresult aResult, nsISupports* aValue) {
     RefPtr<CallbackComplete> event = new CallbackComplete(aResult,
                                                             aValue,
                                                             mCallback.forget());
     return mClone->threadOpenedOn->Dispatch(event, NS_DISPATCH_NORMAL);
   }
 
-  ~AsyncInitializeClone() {
+  ~AsyncInitializeClone() override {
     nsCOMPtr<nsIThread> thread;
     DebugOnly<nsresult> rv = NS_GetMainThread(getter_AddRefs(thread));
     MOZ_ASSERT(NS_SUCCEEDED(rv));
 
     // Handle ambiguous nsISupports inheritance.
     NS_ProxyRelease(thread, mConnection.forget());
     NS_ProxyRelease(thread, mClone.forget());
 
--- a/storage/test/test_AsXXX_helpers.cpp
+++ b/storage/test/test_AsXXX_helpers.cpp
@@ -16,17 +16,17 @@
 
 class Spinner : public AsyncStatementSpinner
 {
 public:
   NS_DECL_ISUPPORTS_INHERITED
   NS_DECL_ASYNCSTATEMENTSPINNER
   Spinner() {}
 protected:
-  virtual ~Spinner() = default;
+  ~Spinner() override = default;
 };
 
 NS_IMPL_ISUPPORTS_INHERITED0(Spinner,
                              AsyncStatementSpinner)
 
 NS_IMETHODIMP
 Spinner::HandleResult(mozIStorageResultSet *aResultSet)
 {