Bug 1318163 - Remove unimplemented and non-spec getStreamById from RTCPeerConnection. draft
authorJan-Ivar Bruaroey <jib@mozilla.com>
Wed, 16 Nov 2016 18:50:49 -0500
changeset 440050 dfdce74b86cee9abda7888f1c99df6769ffa1c42
parent 439734 51750761f2c61c64cf0553f6cb5fefd4999d3bc0
child 537301 dcd0c4c79a291cb8a1c5181d2f755ee391d10881
push id36148
push userjbruaroey@mozilla.com
push dateWed, 16 Nov 2016 23:52:10 +0000
bugs1318163
milestone53.0a1
Bug 1318163 - Remove unimplemented and non-spec getStreamById from RTCPeerConnection. MozReview-Commit-ID: CvuxuLEhAz1
dom/media/PeerConnection.js
dom/webidl/RTCPeerConnection.webidl
--- a/dom/media/PeerConnection.js
+++ b/dom/media/PeerConnection.js
@@ -1005,21 +1005,16 @@ RTCPeerConnection.prototype = {
       }));
     });
   },
 
   addStream: function(stream) {
     stream.getTracks().forEach(track => this.addTrack(track, stream));
   },
 
-  getStreamById: function(id) {
-    throw new this._win.DOMException("getStreamById not yet implemented",
-                                     "NotSupportedError");
-  },
-
   addTrack: function(track, stream) {
     if (stream.currentTime === undefined) {
       throw new this._win.DOMException("invalid stream.", "InvalidParameterError");
     }
     this._checkClosed();
     this._senders.forEach(sender => {
       if (sender.track == track) {
         throw new this._win.DOMException("already added.",
--- a/dom/webidl/RTCPeerConnection.webidl
+++ b/dom/webidl/RTCPeerConnection.webidl
@@ -115,18 +115,16 @@ interface RTCPeerConnection : EventTarge
   [ChromeOnly]
   attribute DOMString id;
 
   RTCConfiguration      getConfiguration ();
   [UnsafeInPrerendering, Deprecated="RTCPeerConnectionGetStreams"]
   sequence<MediaStream> getLocalStreams ();
   [UnsafeInPrerendering, Deprecated="RTCPeerConnectionGetStreams"]
   sequence<MediaStream> getRemoteStreams ();
-  [UnsafeInPrerendering]
-  MediaStream? getStreamById (DOMString streamId);
   void addStream (MediaStream stream);
 
   // replaces addStream; fails if already added
   // because a track can be part of multiple streams, stream parameters
   // indicate which particular streams should be referenced in signaling
 
   RTCRtpSender addTrack(MediaStreamTrack track,
                         MediaStream stream,