Bug 1306329 part C - things that depend on xul should no longer link the XPCOM glue library, r?glandium draft
authorBenjamin Smedberg <benjamin@smedbergs.us>
Tue, 01 Nov 2016 15:14:52 -0400
changeset 447529 9900e939a1078a6ad39312bbe3dfc758aa488ac8
parent 447528 d4dcfe752b3b6ae69b677704afa265a3b41119a9
child 447530 f83e05b01053b078575ddd69532d040964a89ce6
push id38073
push userbsmedberg@mozilla.com
push dateMon, 05 Dec 2016 20:27:48 +0000
reviewersglandium
bugs1306329
milestone53.0a1
Bug 1306329 part C - things that depend on xul should no longer link the XPCOM glue library, r?glandium MozReview-Commit-ID: Hk1rrNONChb
build/gecko_templates.mozbuild
--- a/build/gecko_templates.mozbuild
+++ b/build/gecko_templates.mozbuild
@@ -21,40 +21,38 @@ def GeckoBinary(linkage='dependent', msv
     ought to be linked: 'static' or 'dynamic'.
 
     `mozglue` indicates whether to link against the mozglue library, and if
     so, what linkage to apply. Valid values are None (mozglue not linked),
     'program' (mozglue linked to an executable program), or 'library' (mozglue
     linked to a shared library).
     '''
     if msvcrt == 'dynamic' or CONFIG['OS_ARCH'] != 'WINNT' or CONFIG['MOZ_ASAN']:
-        xpcomglue = 'xpcomglue'
+        pass
     elif msvcrt == 'static':
         USE_STATIC_LIBS = True
-        xpcomglue = 'xpcomglue_staticruntime'
         if not CONFIG['GNU_CC']:
             mozglue = None
             if linkage == 'dependent':
                 USE_LIBS += [
                     'mozalloc_staticruntime',
                 ]
     else:
         error('msvcrt must be "dynamic" or "static"')
 
     if linkage == 'dependent':
         USE_LIBS += [
             'nspr',
-            '%s_s' % xpcomglue,
             'xul',
         ]
     elif linkage == 'standalone':
         DEFINES['XPCOM_GLUE'] = True
 
         USE_LIBS += [
-            xpcomglue,
+            'xpcomglue',
         ]
     elif linkage != None:
         error('`linkage` must be "dependent", "standalone" or None')
 
     if mozglue:
         LDFLAGS += CONFIG['MOZ_GLUE_WRAP_LDFLAGS']
         if mozglue == 'program':
             USE_LIBS += ['mozglue']