Bug 1317386 - Check pointer interactability upon interaction; r?automatedtester
Checking for general interactability will also consider keyboard
interactability, which has not yet been implemented. On interacting with
an element by clicking, we should only test for pointer interactability.
MozReview-Commit-ID: BUCs7zHppRm
--- a/testing/marionette/interaction.js
+++ b/testing/marionette/interaction.js
@@ -117,20 +117,20 @@ interaction.clickElement = function*(el,
let visibilityCheckEl = el;
if (el.localName == "option") {
visibilityCheckEl = interaction.getSelectForOptionElement(el);
}
let interactable = false;
if (specCompat) {
- if (!element.isInteractable(visibilityCheckEl)) {
- el.scrollIntoView(false);
+ if (!element.isPointerInteractable(visibilityCheckEl)) {
+ element.scrollIntoView(el);
}
- interactable = element.isInteractable(visibilityCheckEl);
+ interactable = element.isPointerInteractable(visibilityCheckEl);
} else {
interactable = element.isVisible(visibilityCheckEl);
}
if (!interactable) {
throw new ElementNotVisibleError();
}
if (!atom.isElementEnabled(el)) {