MozReview: Review Page Redesign: Prevent reviewboard from calculating main content height (Bug 1309964). r?glob draft
authorDavid Walsh <dwalsh@mozilla.com>
Thu, 10 Nov 2016 13:47:30 -0600
changeset 217 6540daf171090dfa8a8ebe3ae930761ae79c2e24
parent 216 fc430c7846bb18694957d7b2f75e5a061cbed648
child 218 6fef8be0c6f11b65bdf1fb6504e23d5173d2e983
child 220 c73aec542ac767bbfb968aaa6fb022fba362e1af
child 222 764961bd05872cec3aa846388d651353f0c224a8
child 227 7f949dad18946bc58d1abfe2513f8404ca79c52a
child 233 bb7398d02b086984a5678a5d5628bedf43232408
push idunknown
push userunknown
push dateunknown
reviewersglob
bugs1309964
MozReview: Review Page Redesign: Prevent reviewboard from calculating main content height (Bug 1309964). r?glob MozReview-Commit-ID: CEvvyILqU1A
reviewboard/reviewboard/static/rb/js/views/reviewRequestEditorView_mozreview.js
--- a/reviewboard/reviewboard/static/rb/js/views/reviewRequestEditorView_mozreview.js
+++ b/reviewboard/reviewboard/static/rb/js/views/reviewRequestEditorView_mozreview.js
@@ -1353,18 +1353,16 @@ RB.ReviewRequestEditorView = Backbone.Vi
             editor.setSize(null, 'auto');
         }
 
         /*
          * Set the review request box's main height to take up the full
          * amount of spaces between its top and the top of the "extra"
          * pane (where the issue summary table and stuff live).
          */
-        this._$main.height(this._$extra.offset().top -
-                           this._$main.offset().top);
         height = this._$main.height();
 
         if ($lastContent.outerHeight() + lastContentTop < height) {
             $lastContent.outerHeight(height - lastContentTop);
 
             /*
              * Get the size of the content box, and factor in the padding at
              * the bottom, to balance out position()'s calculation of the