Bug 1313751 - fix direction of URLs and/or page titles in a number of UI elements, r?enndeakin draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Tue, 08 Nov 2016 17:20:05 +0000
changeset 435423 49f110627d6da1eab1c70c8f37aaeaef1d0bacfa
parent 435182 f13e90d496cf1bc6dfc4fd398da33e4afe785bde
child 536310 fcd469e8eb291a6aebd25ad80e2c503e7df358a3
push id35039
push userbmo:gijskruitbosch+bugs@gmail.com
push dateTue, 08 Nov 2016 17:44:22 +0000
reviewersenndeakin
bugs1313751
milestone52.0a1
Bug 1313751 - fix direction of URLs and/or page titles in a number of UI elements, r?enndeakin MozReview-Commit-ID: KmWeWD0MLBM
browser/base/content/browser.css
browser/components/places/content/places.css
browser/components/places/content/placesOverlay.xul
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -615,16 +615,22 @@ toolbar:not(#TabsToolbar) > #personal-bo
 #back-button > .toolbarbutton-menu-dropmarker,
 #forward-button > .toolbarbutton-menu-dropmarker {
   display: none;
 }
 .unified-nav-current {
   font-weight: bold;
 }
 
+.bookmark-item > label {
+  /* ensure we use the direction of the bookmarks label instead of the
+   * browser locale */
+  unicode-bidi: plaintext;
+}
+
 toolbarbutton.bookmark-item {
   max-width: 13em;
 }
 
 /* Apply crisp rendering for favicons at exactly 2dppx resolution */
 @media (resolution: 2dppx) {
   #alltabs-popup > .menuitem-iconic > .menu-iconic-left > .menu-iconic-icon,
   .menuitem-with-favicon > .menu-iconic-left > .menu-iconic-icon {
--- a/browser/components/places/content/places.css
+++ b/browser/components/places/content/places.css
@@ -1,16 +1,22 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 tree[type="places"] {
   -moz-binding: url("chrome://browser/content/places/tree.xml#places-tree");
 }
 
+tree[type="places"] > treechildren::-moz-tree-cell {
+  /* ensure we use the direction of the website title / url instead of the
+   * browser locale */
+  unicode-bidi: plaintext;
+}
+
 .toolbar-drop-indicator {
   position: relative;
   z-index: 1;
 }
 
 menupopup[placespopup="true"] {
   -moz-binding: url("chrome://browser/content/places/menu.xml#places-popup-base");
 }
--- a/browser/components/places/content/placesOverlay.xul
+++ b/browser/components/places/content/placesOverlay.xul
@@ -37,17 +37,17 @@
   <script type="application/javascript"
           src="chrome://browser/content/places/treeView.js"/>
 
   <!-- Bookmarks and history tooltip -->
   <tooltip id="bhTooltip" noautohide="true"
            onpopupshowing="return window.top.BookmarksEventHandler.fillInBHTooltip(document, event)">
     <vbox id="bhTooltipTextBox" flex="1">
       <label id="bhtTitleText" class="tooltip-label" />
-      <label id="bhtUrlText" crop="center" class="tooltip-label" />
+      <label id="bhtUrlText" crop="center" class="tooltip-label uri-element" />
     </vbox>
   </tooltip>
 
   <commandset id="placesCommands"
               commandupdater="true"
               events="focus,sort,places"
               oncommandupdate="goUpdatePlacesCommands();">
     <command id="placesCmd_open"