Bug 1315716 - Use selectableItemBackground for material ripple on ActivityStream cards r?sebastian draft
authorAndrzej Hunt <ahunt@mozilla.com>
Tue, 08 Nov 2016 08:00:10 -0500
changeset 435383 25c298336dde28e90beb4274294e82ccac9d9103
parent 435328 4bb7607609e76f4161ceabee257b95f349dd5c98
child 435384 60235315c78c56655049c6e552a9c25085f1a4e4
push id35029
push userahunt@mozilla.com
push dateTue, 08 Nov 2016 15:44:29 +0000
reviewerssebastian
bugs1315716
milestone52.0a1
Bug 1315716 - Use selectableItemBackground for material ripple on ActivityStream cards r?sebastian MozReview-Commit-ID: KQvNTB5RVbQ
mobile/android/base/resources/layout/activity_stream_card_history_item.xml
mobile/android/base/resources/layout/activity_stream_topsites_card.xml
--- a/mobile/android/base/resources/layout/activity_stream_card_history_item.xml
+++ b/mobile/android/base/resources/layout/activity_stream_card_history_item.xml
@@ -14,17 +14,18 @@
     android:layout_marginStart="@dimen/activity_stream_base_margin"
     android:layout_marginTop="0dp"
     android:orientation="vertical">
 
     <RelativeLayout
         android:layout_width="fill_parent"
         android:layout_height="match_parent"
         android:orientation="horizontal"
-        android:padding="10dp">
+        android:padding="10dp"
+        android:background="?android:attr/selectableItemBackground">
 
         <org.mozilla.gecko.widget.FaviconView
             android:id="@+id/icon"
             android:layout_width="@dimen/favicon_bg"
             android:layout_height="@dimen/favicon_bg"
             android:layout_gravity="center"
             gecko:enableRoundCorners="false"
             tools:background="@drawable/favicon_globe" />
--- a/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
+++ b/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
@@ -3,17 +3,18 @@
     xmlns:gecko="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content">
 
     <RelativeLayout
         android:id="@+id/content"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content">
+        android:layout_height="wrap_content"
+        android:background="?android:attr/selectableItemBackground">
 
         <org.mozilla.gecko.widget.FaviconView
             android:id="@+id/favicon"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_above="@+id/title"
             android:layout_alignParentTop="true"
             android:layout_centerHorizontal="true"