Bug 764573 - Remove MAX_SCHEMA_RETRY since now the default value is larger. r=asuth draft
authorMarco Bonardo <mbonardo@mozilla.com>
Sat, 05 Nov 2016 16:56:33 +0100
changeset 434394 81a0a75cf67be0be26ed286d34ebef960774bd07
parent 434393 0b662725811a63316aeee014e6a4449ef0736916
child 536055 3736543572725b9b55f8247d56ed5d29f1a0e13c
push id34758
push usermak77@bonardo.net
push dateSat, 05 Nov 2016 15:58:03 +0000
reviewersasuth
bugs764573
milestone52.0a1
Bug 764573 - Remove MAX_SCHEMA_RETRY since now the default value is larger. r=asuth MozReview-Commit-ID: IgHRBAq4lmn
db/sqlite3/src/moz.build
--- a/db/sqlite3/src/moz.build
+++ b/db/sqlite3/src/moz.build
@@ -28,28 +28,24 @@ SOURCES += [
 # -DSQLITE_ENABLE_FTS3=1 enables the full-text index module.
 # -DSQLITE_CORE=1 statically links that module into the SQLite library.
 # -DSQLITE_DEFAULT_PAGE_SIZE=32768 and SQLITE_MAX_DEFAULT_PAGE_SIZE=32768
 # increases the page size from 1k, see bug 416330.  It must be kept in sync with
 # the value of PREF_TS_PAGESIZE_DEFAULT in mozStorageService.cpp.  The value can
 # be overridden on a per-platform basis through the use of the PREF_TS_PAGESIZE
 # hidden preference.  If that preference is missing or invalid then this value
 # will be used.
-# -DSQLITE_MAX_SCHEMA_RETRY increases the times SQLite may try to reparse
-# statements when the schema changes. This is important when supporting lots of
-# concurrent connections, especially when they use shared cache.
 # Note: Be sure to update the configure.in checks when these change!
 for var in ('SQLITE_SECURE_DELETE', 'SQLITE_THREADSAFE', 'SQLITE_CORE',
             'SQLITE_ENABLE_FTS3', 'SQLITE_ENABLE_UNLOCK_NOTIFY',
             'SQLITE_ENABLE_DBSTAT_VTAB'):
     DEFINES[var] = 1
 
 DEFINES['SQLITE_DEFAULT_PAGE_SIZE'] = 32768
 DEFINES['SQLITE_MAX_DEFAULT_PAGE_SIZE'] = 32768
-DEFINES['SQLITE_MAX_SCHEMA_RETRY'] = 25
 
 # -DSQLITE_WIN32_GETVERSIONEX=0 avoids using deprecated functions.
 # SQLite will just assume we are running on NT kinds of Windows. That's fine
 # because we don't support Win9x.
 # -DSQLITE_ALLOW_URI_AUTHORITY=1 enables uri authorities. See bug 879133.
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
     DEFINES['SQLITE_WIN32_GETVERSIONEX'] = 0
     DEFINES['SQLITE_ALLOW_URI_AUTHORITY'] = 1