Bug 1314749 - Copy l10nId, not label and accesskey between elements. r?pike draft
authorZibi Braniecki <gandalf@mozilla.com>
Thu, 03 Nov 2016 17:42:01 -0700
changeset 433544 ad623d92a8547fb6c8601bcac766da45ae9b9409
parent 433507 90cd361471431dd07ef43061e1b8c537d2530560
child 535927 bee7732fff5a5087bc6b4dae6280c2edb9a36584
push id34620
push userzbraniecki@mozilla.com
push dateFri, 04 Nov 2016 00:42:54 +0000
reviewerspike
bugs1314749
milestone52.0a1
Bug 1314749 - Copy l10nId, not label and accesskey between elements. r?pike MozReview-Commit-ID: BxzjOyoAd1k
browser/base/content/browser.js
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -7545,18 +7545,18 @@ var gPrivateBrowsingUI = {
         // Adjust the New Window menu entries
         [
           { normal: "menu_newNavigator", private: "menu_newPrivateWindow" },
         ].forEach(function(menu) {
           let newWindow = document.getElementById(menu.normal);
           let newPrivateWindow = document.getElementById(menu.private);
           if (newWindow && newPrivateWindow) {
             newPrivateWindow.hidden = true;
-            newWindow.label = newPrivateWindow.label;
-            newWindow.accessKey = newPrivateWindow.accessKey;
+            newWindow.setAttribute(
+              'data-l10n-id', newPrivateWindow.getAttribute('data-l10n-id'));
             newWindow.command = newPrivateWindow.command;
           }
         });
       }
     }
 
     let urlBarSearchParam = gURLBar.getAttribute("autocompletesearchparam") || "";
     if (!PrivateBrowsingUtils.permanentPrivateBrowsing &&