Bug 1311925 - Remove yellow highlight from search boxes. r=gl draft
authorTim Nguyen <ntim.bugs@gmail.com>
Thu, 03 Nov 2016 19:18:16 +0000
changeset 433467 bebc42eeacb99d3beaeb8431576b7f0eda88de81
parent 431500 969c3295d3aa77931cca26eddb047d9d74bd9858
child 535899 b6732e18c2b6d9e41b07f7d570c93a57a615072d
push id34589
push userbmo:ntim.bugs@gmail.com
push dateThu, 03 Nov 2016 19:18:38 +0000
reviewersgl
bugs1311925
milestone52.0a1
Bug 1311925 - Remove yellow highlight from search boxes. r=gl MozReview-Commit-ID: Bxu6uMKw7LM
devtools/client/inspector/inspector-search.js
devtools/client/themes/common.css
--- a/devtools/client/inspector/inspector-search.js
+++ b/devtools/client/inspector/inspector-search.js
@@ -107,21 +107,19 @@ InspectorSearch.prototype = {
       this.searchBox.classList.add("devtools-style-searchbox-no-match");
       this.emit("search-result");
     }
   }),
 
   _onInput: function () {
     if (this.searchBox.value.length === 0) {
       this.searchClearButton.hidden = true;
-      this.searchBox.removeAttribute("filled");
       this._onSearch();
     } else {
       this.searchClearButton.hidden = false;
-      this.searchBox.setAttribute("filled", true);
     }
   },
 
   _onKeyDown: function (event) {
     if (event.keyCode === KeyCodes.DOM_VK_RETURN) {
       this._onSearch(event.shiftKey);
     }
 
--- a/devtools/client/themes/common.css
+++ b/devtools/client/themes/common.css
@@ -629,17 +629,16 @@ checkbox:-moz-focusring {
   padding-inline-end: 0;
 }
 
 .devtools-rule-searchbox {
   -moz-box-flex: 1;
   width: 100%;
 }
 
-.devtools-searchinput:-moz-any([filled],.filled),
 .devtools-filterinput:-moz-any([filled],.filled) {
   background-color: var(--searchbox-background-color);
   border-color: var(--searchbox-border-color);
 }
 
 .devtools-style-searchbox-no-match {
   background-color: var(--searcbox-no-match-background-color) !important;
   border-color: var(--searcbox-no-match-border-color) !important;