Bug 1314981 - Remove clean working directory check; r?dustin
As the inline comment says, this was meant to be temporary. The check
has never fired AFAIK. The check adds ~5s overhead to run-task when
there is a source checkout. So let's remove it and get our time back.
MozReview-Commit-ID: FqwCaDAyiSE
--- a/testing/docker/recipes/run-task
+++ b/testing/docker/recipes/run-task
@@ -130,29 +130,16 @@ def vcs_checkout(source_repo, dest, stor
source_repo, dest,
])
res = run_and_prefix_output(b'vcs', args,
extra_env={b'PYTHONUNBUFFERED': b'1'})
if res:
sys.exit(res)
- # Meant to be temporary to flush out what's going on in bug 1292071.
- print_line(b'vcs', b'verifying working directory is clean\n')
- status = subprocess.check_output([b'/usr/bin/hg', b'status', b'--all'],
- cwd=dest, stderr=subprocess.STDOUT)
- status = status.strip()
- status_lines = [l for l in status.splitlines() if not l.startswith(b'C ')]
- if status_lines:
- print_line(b'vcs', b'Error: checkout is not pristine! '
- b'Report this in bug 1292071\n')
- for line in status_lines:
- print_line(b'vcs', b'%s\n' % line)
- sys.exit(1)
-
# Update the current revision hash and ensure that it is well formed.
revision = subprocess.check_output(
[b'/usr/bin/hg', b'log',
b'--rev', b'.',
b'--template', b'{node}'],
cwd=dest)
assert re.match('^[a-f0-9]{40}$', revision)