Bug 1314526. Part 5 - fix HandleWaitingForData(). draft
authorJW Wang <jwwang@mozilla.com>
Fri, 28 Oct 2016 16:31:54 +0800
changeset 433074 d8840c0840eda6859e83ac11ad93b16942685957
parent 433073 a08bbe39dcd6b80ca439b02456284a08a7f0ebea
child 433075 236a600b4960b2c1fe008cd5f5300acaef019c43
push id34475
push userjwwang@mozilla.com
push dateThu, 03 Nov 2016 03:28:38 +0000
bugs1314526
milestone52.0a1
Bug 1314526. Part 5 - fix HandleWaitingForData(). MozReview-Commit-ID: KHPpdZFt9Tt
dom/media/MediaDecoderStateMachine.cpp
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -192,18 +192,17 @@ public:
   virtual void Step() {}   // Perform a 'cycle' of this state object.
   virtual State GetState() const = 0;
 
   // Event handlers for various events.
   virtual void HandleCDMProxyReady() {}
   virtual void HandleAudioDecoded(MediaData* aAudio) {}
   virtual void HandleVideoDecoded(MediaData* aVideo, TimeStamp aDecodeStart) {}
   virtual void HandleEndOfStream() {}
-
-  virtual bool HandleWaitingForData() { return false; }
+  virtual void HandleWaitingForData() {}
 
   virtual RefPtr<MediaDecoder::SeekPromise> HandleSeek(SeekTarget aTarget) = 0;
 
   virtual bool HandleAudioCaptured() { return false; }
 
   virtual RefPtr<ShutdownPromise> HandleShutdown();
 
   virtual void HandleVideoSuspendTimeout() = 0;
@@ -582,20 +581,19 @@ public:
     MaybeStopPrerolling();
     CheckSlowDecoding(aDecodeStart);
   }
 
   RefPtr<MediaDecoder::SeekPromise> HandleSeek(SeekTarget aTarget) override;
 
   void HandleEndOfStream() override;
 
-  bool HandleWaitingForData() override
+  void HandleWaitingForData() override
   {
     MaybeStopPrerolling();
-    return true;
   }
 
   bool HandleAudioCaptured() override
   {
     MaybeStopPrerolling();
     // MediaSink is changed. Schedule Step() to check if we can start playback.
     mMaster->ScheduleStateMachine();
     return true;