Bug 1312416 - use tabbrowser message manager group to listen for decoder doctor messages, r?jaws draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 28 Oct 2016 18:15:30 +0100
changeset 431056 fb53eaaf8682819c68ff37c3cae094ebee383a1f
parent 428241 5639a9f476d08f300c079117e61697f5026b6367
child 535354 7ef7e32a36ca3d1cd15549e7330adfdcd8709e74
push id33991
push usergijskruitbosch@gmail.com
push dateFri, 28 Oct 2016 17:16:10 +0000
reviewersjaws
bugs1312416
milestone52.0a1
Bug 1312416 - use tabbrowser message manager group to listen for decoder doctor messages, r?jaws For browsers in e.g. panels, we can't really make decoder doctor work well, so we simply elect to only listen for such messages within tabbrowser browsers. MozReview-Commit-ID: Frrhf6AOgAy
browser/base/content/browser-media.js
--- a/browser/base/content/browser-media.js
+++ b/browser/base/content/browser-media.js
@@ -351,14 +351,14 @@ let gDecoderDoctorHandler = {
       // first time we get this resolution -> Clear prefs and report telemetry.
       Services.prefs.clearUserPref(formatsPref);
       Services.prefs.clearUserPref(buttonClickedPref);
       histogram.add(decoderDoctorReportId, TELEMETRY_DDSTAT_SOLVED);
     }
   },
 }
 
-window.messageManager.addMessageListener("DecoderDoctor:Notification", gDecoderDoctorHandler);
-window.messageManager.addMessageListener("EMEVideo:ContentMediaKeysRequest", gEMEHandler);
+window.getGroupMessageManager("browsers").addMessageListener("DecoderDoctor:Notification", gDecoderDoctorHandler);
+window.getGroupMessageManager("browsers").addMessageListener("EMEVideo:ContentMediaKeysRequest", gEMEHandler);
 window.addEventListener("unload", function() {
-  window.messageManager.removeMessageListener("EMEVideo:ContentMediaKeysRequest", gEMEHandler);
-  window.messageManager.removeMessageListener("DecoderDoctor:Notification", gDecoderDoctorHandler);
+  window.getGroupMessageManager("browsers").removeMessageListener("EMEVideo:ContentMediaKeysRequest", gEMEHandler);
+  window.getGroupMessageManager("browsers").removeMessageListener("DecoderDoctor:Notification", gDecoderDoctorHandler);
 }, false);