Bug 1313363 - NotificationClient: Use BigTextStyle instead of InboxStyle. r?grisha draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Fri, 28 Oct 2016 17:18:52 +0200
changeset 431009 91f46c156cbfe7f0b2f30757116c3e0a93835dba
parent 430968 c66b3b7a7b05a6bd84488de4827abd9c3f6225d8
child 535338 5f97e751ffe99932f360f16e40cce6daa6269d2a
push id33974
push users.kaspari@gmail.com
push dateFri, 28 Oct 2016 15:21:07 +0000
reviewersgrisha
bugs1313363
milestone52.0a1
Bug 1313363 - NotificationClient: Use BigTextStyle instead of InboxStyle. r?grisha There's no reason to use InboxStyle here. We do not add any items to the list. Currently the content text is truncated aggressively showing only one line of text. With BigTextStyle we can show a lot more. MozReview-Commit-ID: 8CQZVHzc7b8
mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java
--- a/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java
+++ b/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationClient.java
@@ -142,19 +142,19 @@ public final class NotificationClient im
                      final PendingIntent contentIntent, final PendingIntent deleteIntent) {
         final NotificationCompat.Builder builder = new NotificationCompat.Builder(mContext)
                 .setContentTitle(alertTitle)
                 .setContentText(alertText)
                 .setSmallIcon(R.drawable.ic_status_logo)
                 .setContentIntent(contentIntent)
                 .setDeleteIntent(deleteIntent)
                 .setAutoCancel(true)
-                .setStyle(new NotificationCompat.InboxStyle()
-                          .addLine(alertText)
-                          .setSummaryText(host));
+                .setStyle(new NotificationCompat.BigTextStyle()
+                        .bigText(alertText)
+                        .setSummaryText(host));
 
         // Fetch icon.
         if (!imageUrl.isEmpty()) {
             final Bitmap image = BitmapUtils.decodeUrl(imageUrl);
             builder.setLargeIcon(image);
         }
 
         builder.setWhen(System.currentTimeMillis());