Bug 1313280 - Suppress warnings from third-party sources. r?glandium draft
authorMasatoshi Kimura <VYV03354@nifty.ne.jp>
Fri, 04 Nov 2016 22:51:17 +0900
changeset 433964 e4ea99c3874e2bc219328d90f856c2ca35c53a57
parent 433963 5bae7fd07506b628411c12528225ab7367171dd3
child 433965 45b6190dd05f6e7b92f7a24b9062faa04b38631c
push id34692
push userVYV03354@nifty.ne.jp
push dateFri, 04 Nov 2016 15:15:22 +0000
reviewersglandium
bugs1313280
milestone52.0a1
Bug 1313280 - Suppress warnings from third-party sources. r?glandium MozReview-Commit-ID: 4R6mPbWIrAm MozReview-Commit-ID: D15liHKGXHv MozReview-Commit-ID: KQj3wDLxRZI
dom/media/platforms/omx/moz.build
media/webrtc/moz.build
--- a/dom/media/platforms/omx/moz.build
+++ b/dom/media/platforms/omx/moz.build
@@ -43,8 +43,15 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk
     EXTRA_DSO_LDOPTS += [
         '-libbinder',
     ]
 
 FINAL_LIBRARY = 'xul'
 
 if CONFIG['GNU_CXX']:
     CXXFLAGS += ['-Wno-error=shadow']
+
+if CONFIG['_MSC_VER']:
+    # Avoid warnings from third-party code that we can not modify.
+    if CONFIG['CLANG_CL']:
+        CXXFLAGS += ['-Wno-invalid-source-encoding']
+    else:
+        CXXFLAGS += ['-validate-charset-']
--- a/media/webrtc/moz.build
+++ b/media/webrtc/moz.build
@@ -89,16 +89,23 @@ if CONFIG['MOZ_WEBRTC_SIGNALING']:
         'signaling/src/sdp/sipcc/sdp_services_unix.c',
         'signaling/src/sdp/sipcc/sdp_token.c',
         'signaling/src/sdp/sipcc/sdp_utils.c',
     ]
 
     GYP_DIRS['signaling'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
     GYP_DIRS['signaling'].non_unified_sources += signaling_non_unified_sources
 
+    if CONFIG['_MSC_VER']:
+        # Avoid warnings from third-party code that we can not modify.
+        if CONFIG['CLANG_CL']:
+            CXXFLAGS += ['-Wno-invalid-source-encoding']
+        else:
+            CXXFLAGS += ['-validate-charset-']
+
 if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk':
     GYP_DIRS += ['trunk/testing']
     GYP_DIRS['trunk/testing'].input = 'trunk/testing/gtest.gyp'
     GYP_DIRS['trunk/testing'].variables = gyp_vars
     # We allow warnings for third-party code that can be updated from upstream.
     GYP_DIRS['trunk/testing'].sandbox_vars['ALLOW_COMPILER_WARNINGS'] = True
     GYP_DIRS['trunk/testing'].non_unified_sources += webrtc_non_unified_sources