Bug 1302991 - Empty url()s should not load or request anything draft
authorSumit Tiwari <sumi29@gmail.com>
Thu, 27 Oct 2016 19:37:22 -0400
changeset 430569 791df192e09a5c87c5516a4f5928b6ffe8f11dcd
parent 427487 2c0a0eb6f90fecd8252ff018918399567c2bf1df
child 535226 5d3c6442864e66e85d591cf3a11ffd9bed5bb9bf
push id33849
push userbmo:sumi29@gmail.com
push dateThu, 27 Oct 2016 23:40:18 +0000
bugs1302991
milestone52.0a1
Bug 1302991 - Empty url()s should not load or request anything MozReview-Commit-ID: 8O0FQafy7nc
layout/style/nsCSSValue.cpp
--- a/layout/style/nsCSSValue.cpp
+++ b/layout/style/nsCSSValue.cpp
@@ -2713,21 +2713,23 @@ css::URLValueData::DefinitelyEqualURIsAn
 nsIURI*
 css::URLValueData::GetURI() const
 {
   MOZ_ASSERT(NS_IsMainThread());
 
   if (!mURIResolved) {
     MOZ_ASSERT(!mURI);
     nsCOMPtr<nsIURI> newURI;
-    NS_NewURI(getter_AddRefs(newURI),
-              NS_ConvertUTF16toUTF8(nsCSSValue::GetBufferValue(mString)),
-              nullptr, const_cast<nsIURI*>(mBaseURI.get()));
-    mURI = new PtrHolder<nsIURI>(newURI.forget());
-    mURIResolved = true;
+    if (NS_ConvertUTF16toUTF8(nsCSSValue::GetBufferValue(mString)) != "") {
+      NS_NewURI(getter_AddRefs(newURI),
+                NS_ConvertUTF16toUTF8(nsCSSValue::GetBufferValue(mString)),
+                nullptr, const_cast<nsIURI*>(mBaseURI.get()));
+      mURI = new PtrHolder<nsIURI>(newURI.forget());
+      mURIResolved = true;
+    }
   }
 
   return mURI;
 }
 
 already_AddRefed<nsIURI>
 css::URLValueData::ResolveLocalRef(nsIURI* aURI) const
 {