Bug 1313517: Always compute start time with ADTS. r?kamidphish draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 27 Oct 2016 20:12:29 +1100
changeset 430513 1653bb2a8ec8288fb1d3b19e5f801b1b17839238
parent 430512 0014b5d5a60fe1e976edd7c77008a7e6e1bc8479
child 535219 5ae37b58ffefc71505c95d95160cfa6f3b93e377
push id33842
push userbmo:jyavenard@mozilla.com
push dateThu, 27 Oct 2016 22:42:13 +0000
reviewerskamidphish
bugs1313517
milestone52.0a1
Bug 1313517: Always compute start time with ADTS. r?kamidphish This was originally copied from the MP3Demuxer and was only required to work around an issue now fixed. Only MSE should set ShoultComputeStartTime to false, even if the ADTS demuxer always returns a first sample with a time of 0. MozReview-Commit-ID: DMRLpxC5mU1
dom/media/ADTSDemuxer.h
--- a/dom/media/ADTSDemuxer.h
+++ b/dom/media/ADTSDemuxer.h
@@ -27,17 +27,16 @@ public:
   // MediaDataDemuxer interface.
   explicit ADTSDemuxer(MediaResource* aSource);
   RefPtr<InitPromise> Init() override;
   bool HasTrackType(TrackInfo::TrackType aType) const override;
   uint32_t GetNumberTracks(TrackInfo::TrackType aType) const override;
   already_AddRefed<MediaTrackDemuxer> GetTrackDemuxer(
     TrackInfo::TrackType aType, uint32_t aTrackNumber) override;
   bool IsSeekable() const override;
-  bool ShouldComputeStartTime() const override { return false; }
 
 private:
   bool InitInternal();
 
   RefPtr<MediaResource> mSource;
   RefPtr<ADTSTrackDemuxer> mTrackDemuxer;
 };