Bug 1312886: P3. Always compute start time with ADTS. r?kamidphish draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 27 Oct 2016 20:12:29 +1100
changeset 430195 217352a9f74552ceac48383c46e9b4e27e487089
parent 430194 d8acc2c3f0b763ac8bdd7ea27422428bf1fe79f8
child 430196 463306a1d2006db68aee2cf6303b926aac72689f
push id33762
push userbmo:jyavenard@mozilla.com
push dateThu, 27 Oct 2016 09:33:54 +0000
reviewerskamidphish
bugs1312886
milestone52.0a1
Bug 1312886: P3. Always compute start time with ADTS. r?kamidphish This was originally copied from the MP3Demuxer and was only required to work around an issue now fixed. Only MSE should set ShoultComputeStartTime to false, even if the ADTS demuxer always returns a first sample with a time of 0. MozReview-Commit-ID: DMRLpxC5mU1
dom/media/ADTSDemuxer.h
--- a/dom/media/ADTSDemuxer.h
+++ b/dom/media/ADTSDemuxer.h
@@ -27,17 +27,16 @@ public:
   // MediaDataDemuxer interface.
   explicit ADTSDemuxer(MediaResource* aSource);
   RefPtr<InitPromise> Init() override;
   bool HasTrackType(TrackInfo::TrackType aType) const override;
   uint32_t GetNumberTracks(TrackInfo::TrackType aType) const override;
   already_AddRefed<MediaTrackDemuxer> GetTrackDemuxer(
     TrackInfo::TrackType aType, uint32_t aTrackNumber) override;
   bool IsSeekable() const override;
-  bool ShouldComputeStartTime() const override { return false; }
 
 private:
   bool InitInternal();
 
   RefPtr<MediaResource> mSource;
   RefPtr<ADTSTrackDemuxer> mTrackDemuxer;
 };