Bug 1312467 - Move touch target size definition into resources r?sebastian
MozReview-Commit-ID: IKDfFyhQAdS
--- a/mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java
+++ b/mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java
@@ -107,17 +107,17 @@ public abstract class StreamItem extends
DrawableUtil.tintDrawable(menuButton.getContext(), R.drawable.menu, Color.LTGRAY));
itemView.post(new Runnable() {
@Override
public void run() {
Rect delegateArea = new Rect();
menuButton.getHitRect(delegateArea);
- final int targetHitArea = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, 40, itemView.getContext().getResources().getDisplayMetrics());;
+ final int targetHitArea = itemView.getContext().getResources().getDimensionPixelSize(R.dimen.touch_target_size);
final int widthDelta = (targetHitArea - delegateArea.width()) / 2;
delegateArea.right += widthDelta;
delegateArea.left -= widthDelta;
final int heightDelta = (targetHitArea - delegateArea.height()) / 2;
delegateArea.bottom += heightDelta;
delegateArea.top -= heightDelta;
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -221,9 +221,12 @@
<item name="activity_stream_desired_tile_width" type="dimen">90dp</item>
<item name="activity_stream_desired_tile_height" type="dimen">70dp</item>
<item name="activity_stream_top_sites_text_height" type="dimen">30dp</item>
<item name="activity_stream_contextmenu_peek_height" type="dimen">380dp</item>
<!-- note: max_menu_height only affects the scrolling menu, but doesnt' take into consideration
the header above it. -->
<item name="activity_stream_contextmenu_max_menu_height" type="dimen">350dp</item>
+
+ <!-- Default touch target size for buttons/imageviews that might be of small size -->
+ <item name="touch_target_size" type="dimen">40dp</item>
</resources>