Bug 1312467 - Move touch target size definition into resources r?sebastian draft
authorAndrzej Hunt <ahunt@mozilla.com>
Tue, 25 Oct 2016 10:48:22 -0700
changeset 431741 9c085908bb17a7f1eb465d895a78dbf678f756c3
parent 431740 e017b947cea08b7bdd21007e95bd13e14ad59103
child 431742 ac18d0daba6b65202cc3721c0c03dd5123bce9b9
child 431763 d28412cf0806f784dec2ee716825d7c94c91eaf7
push id34100
push userahunt@mozilla.com
push dateMon, 31 Oct 2016 14:16:11 +0000
reviewerssebastian
bugs1312467
milestone52.0a1
Bug 1312467 - Move touch target size definition into resources r?sebastian MozReview-Commit-ID: IKDfFyhQAdS
mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java
mobile/android/base/resources/values/dimens.xml
--- a/mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java
+++ b/mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamItem.java
@@ -107,17 +107,17 @@ public abstract class StreamItem extends
                     DrawableUtil.tintDrawable(menuButton.getContext(), R.drawable.menu, Color.LTGRAY));
 
             itemView.post(new Runnable() {
                 @Override
                 public void run() {
                     Rect delegateArea = new Rect();
                     menuButton.getHitRect(delegateArea);
 
-                    final int targetHitArea = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, 40, itemView.getContext().getResources().getDisplayMetrics());;
+                    final int targetHitArea = itemView.getContext().getResources().getDimensionPixelSize(R.dimen.touch_target_size);
 
                     final int widthDelta = (targetHitArea - delegateArea.width()) / 2;
                     delegateArea.right += widthDelta;
                     delegateArea.left -= widthDelta;
 
                     final int heightDelta = (targetHitArea - delegateArea.height()) / 2;
                     delegateArea.bottom += heightDelta;
                     delegateArea.top -= heightDelta;
--- a/mobile/android/base/resources/values/dimens.xml
+++ b/mobile/android/base/resources/values/dimens.xml
@@ -221,9 +221,12 @@
     <item name="activity_stream_desired_tile_width" type="dimen">90dp</item>
     <item name="activity_stream_desired_tile_height" type="dimen">70dp</item>
     <item name="activity_stream_top_sites_text_height" type="dimen">30dp</item>
 
     <item name="activity_stream_contextmenu_peek_height" type="dimen">380dp</item>
     <!-- note: max_menu_height only affects the scrolling menu, but doesnt' take into consideration
          the header above it. -->
     <item name="activity_stream_contextmenu_max_menu_height" type="dimen">350dp</item>
+
+    <!-- Default touch target size for buttons/imageviews that might be of small size -->
+    <item name="touch_target_size" type="dimen">40dp</item>
 </resources>