Bug 1310149: Tighten the check in DecodeLimits; r?luke
MozReview-Commit-ID: 7uvBAqIY53I
--- a/js/src/asmjs/WasmBinaryFormat.cpp
+++ b/js/src/asmjs/WasmBinaryFormat.cpp
@@ -186,20 +186,18 @@ wasm::DecodeInitializerExpression(Decode
bool
wasm::DecodeLimits(Decoder& d, Limits* limits)
{
uint32_t flags;
if (!d.readVarU32(&flags))
return d.fail("expected flags");
- // TODO (bug 1310149): tighten this check (s/3/1) when the AngryBots demo
- // gets updated.
- if (flags & ~uint32_t(0x3))
- return d.fail("unexpected bits set in flags: %" PRIu32, (flags & ~uint32_t(0x3)));
+ if (flags & ~uint32_t(0x1))
+ return d.fail("unexpected bits set in flags: %" PRIu32, (flags & ~uint32_t(0x1)));
if (!d.readVarU32(&limits->initial))
return d.fail("expected initial length");
if (flags & 0x1) {
uint32_t maximum;
if (!d.readVarU32(&maximum))
return d.fail("expected maximum length");