Bug 1312716 - '-preferences' on the command line no longer works due to an undefined variable. r?mikedeboer draft
authorMark Banner <standard8@mozilla.com>
Tue, 25 Oct 2016 13:35:43 +0100
changeset 429190 e112f72a18cc58e0470dce6c74718543f3771ef2
parent 429179 c6ccd71126ff514bfc44b53e2217562e29a0cc38
child 534916 8b05a5f9c4a701d8f18960f7129f1d607f2ed7ff
push id33504
push userbmo:standard8@mozilla.com
push dateTue, 25 Oct 2016 12:36:51 +0000
reviewersmikedeboer
bugs1312716
milestone52.0a1
Bug 1312716 - '-preferences' on the command line no longer works due to an undefined variable. r?mikedeboer MozReview-Commit-ID: LclZ8IrSPjb
browser/components/nsBrowserContentHandler.js
--- a/browser/components/nsBrowserContentHandler.js
+++ b/browser/components/nsBrowserContentHandler.js
@@ -1,12 +1,14 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
+/* eslint no-undef:2 */
+
 Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
 Components.utils.import("resource://gre/modules/Services.jsm");
 Components.utils.import("resource://gre/modules/AppConstants.jsm");
 
 XPCOMUtils.defineLazyModuleGetter(this, "LaterRun",
                                   "resource:///modules/LaterRun.jsm");
 XPCOMUtils.defineLazyModuleGetter(this, "PrivateBrowsingUtils",
                                   "resource://gre/modules/PrivateBrowsingUtils.jsm");
@@ -226,17 +228,17 @@ function openWindow(parent, url, target,
 function openPreferences() {
   var args = Components.classes["@mozilla.org/array;1"]
                      .createInstance(Components.interfaces.nsIMutableArray);
 
   var wuri = Components.classes["@mozilla.org/supports-string;1"]
                        .createInstance(Components.interfaces.nsISupportsString);
   wuri.data = "about:preferences";
 
-  sa.appendElement(wuri, /*weak =*/ false);
+  args.appendElement(wuri, /*weak =*/ false);
 
   Services.ww.openWindow(null, gBrowserContentHandler.chromeURL,
                          "_blank",
                          "chrome,dialog=no,all",
                          args);
 }
 
 function logSystemBasedSearch(engine) {