Bug 1312304: Don't MOZ_CRASH when we use ICE policy "none". r?drno draft
authorByron Campen [:bwc] <docfaraday@gmail.com>
Mon, 24 Oct 2016 10:32:34 -0500
changeset 428737 ed4e3959562ad852bcab8c15d7741102d951f57c
parent 428736 c845bfd0accb7e0c29b41713255963b08006e701
child 534823 f9f8da1d25ecbdf67aae2fba3ac50430b2dc362e
push id33405
push userbcampen@mozilla.com
push dateMon, 24 Oct 2016 15:32:53 +0000
reviewersdrno
bugs1312304
milestone52.0a1
Bug 1312304: Don't MOZ_CRASH when we use ICE policy "none". r?drno MozReview-Commit-ID: CmRk7o4GdLc
media/mtransport/nricectx.cpp
--- a/media/mtransport/nricectx.cpp
+++ b/media/mtransport/nricectx.cpp
@@ -531,17 +531,17 @@ NrIceCtx::Initialize(const std::string& 
   // Create the ICE context
   int r;
 
   UINT4 flags = offerer_ ? NR_ICE_CTX_FLAGS_OFFERER:
       NR_ICE_CTX_FLAGS_ANSWERER;
   flags |= NR_ICE_CTX_FLAGS_AGGRESSIVE_NOMINATION;
   switch (policy_) {
     case ICE_POLICY_NONE:
-      MOZ_CRASH();
+      // This will suppress gathering and ICE checks.
       break;
     case ICE_POLICY_RELAY:
       flags |= NR_ICE_CTX_FLAGS_RELAY_ONLY;
       break;
     case ICE_POLICY_NO_HOST:
       flags |= NR_ICE_CTX_FLAGS_HIDE_HOST_CANDIDATES;
       break;
     case ICE_POLICY_ALL: