Bug 1310956 - Use arm64 for target_arch into GYP. r?glandium draft
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 21 Oct 2016 14:48:24 +0900
changeset 427938 5287676d852a39936913a0106dfe1671d1b2d632
parent 427779 f0f1aaf051d6798e1e73d1feee07ca847333167a
child 534606 57918a618eb445fe3d6d0a9c181d621e852f25a6
push id33175
push userm_kato@ga2.so-net.ne.jp
push dateFri, 21 Oct 2016 06:10:36 +0000
reviewersglandium
bugs1310956
milestone52.0a1
Bug 1310956 - Use arm64 for target_arch into GYP. r?glandium Google's projects using GYP use arm64 for target_arch instead of aarch64. So we should use it for moz.build generator. MozReview-Commit-ID: J4SLKhCqyUo
build/gyp.mozbuild
media/webrtc/trunk/build/common.gypi
--- a/build/gyp.mozbuild
+++ b/build/gyp.mozbuild
@@ -104,16 +104,17 @@ flavors = {
     'NetBSD': 'netbsd',
     'OpenBSD': 'openbsd',
 }
 gyp_vars['OS'] = flavors.get(os)
 
 arches = {
     'x86_64': 'x64',
     'x86': 'ia32',
+    'aarch64': 'arm64',
 }
 
 gyp_vars['target_arch'] = arches.get(CONFIG['CPU_ARCH'], CONFIG['CPU_ARCH'])
 
 if CONFIG['ARM_ARCH']:
     if int(CONFIG['ARM_ARCH']) < 7:
         gyp_vars['armv7'] = 0
         gyp_vars['arm_neon_optional'] = 0
--- a/media/webrtc/trunk/build/common.gypi
+++ b/media/webrtc/trunk/build/common.gypi
@@ -1022,17 +1022,17 @@
                 'conditions': [
                   ['armv7==0', {
                     'android_app_abi%': 'armeabi',
                   }, {
                     'android_app_abi%': 'armeabi-v7a',
                   }],
                 ],
               }],
-              ['target_arch=="aarch64"', {
+              ['target_arch=="arm64"', {
                 'android_app_abi%': 'arm64-v8a',
                 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-21/arch-arm64',
               }],
             ],
           },
           'android_ndk_root%': '<(android_ndk_root)',
           'android_app_abi%': '<(android_app_abi)',
           'android_ndk_sysroot%': '<(android_ndk_sysroot)',