Bug 1311741 - Remove "--non-constant-id" from aapt invocations r?nalexander draft
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 20 Oct 2016 09:41:26 -0700
changeset 427606 513702675b3dc1f3812b385abf49bf9fb4403920
parent 427605 c0546f301155bf7d741b87ee835b3f9205b097d8
child 427830 625c189784aee5482b3ebcaf3875a3329c5a673b
push id33065
push userahunt@mozilla.com
push dateThu, 20 Oct 2016 16:42:26 +0000
reviewersnalexander
bugs1311741
milestone52.0a1
Bug 1311741 - Remove "--non-constant-id" from aapt invocations r?nalexander This flag seems to no longer be needed, and prevents the use of switch statements for resource ID's. It was first introduced for mach based geckoview builds, however geckoview now seems to be built using gradle which is able to invoke aapt to produce better R.java's, resulting in constant Resource ID's in Fennec. MozReview-Commit-ID: EjWCX4nvlht
mobile/android/base/Makefile.in
--- a/mobile/android/base/Makefile.in
+++ b/mobile/android/base/Makefile.in
@@ -471,17 +471,16 @@ define aapt_command
 		-I $(ANDROID_SDK)/android.jar \
 		$(if $(MOZ_ANDROID_MAX_SDK_VERSION),--max-res-version $(MOZ_ANDROID_MAX_SDK_VERSION),) \
 		--auto-add-overlay \
 		$$(addprefix -S ,$$(ANDROID_RES_DIRS)) \
 		$$(addprefix -A ,$$(ANDROID_ASSETS_DIRS)) \
 		$(if $(ANDROID_EXTRA_PACKAGES),--extra-packages $$(subst $$(NULL) ,:,$$(strip $$(ANDROID_EXTRA_PACKAGES)))) \
 		$(if $(ANDROID_EXTRA_RES_DIRS),$$(addprefix -S ,$$(ANDROID_EXTRA_RES_DIRS))) \
 		--custom-package org.mozilla.gecko \
-		--non-constant-id \
 		--no-version-vectors \
 		-F $(3) \
 		-J $(4) \
 		--output-text-symbols $(5) \
 		--ignore-assets "$$(ANDROID_AAPT_IGNORE)"
 endef
 
 # [Comment 3/3] The first of these rules is used during regular