Bug 1307645 - Avoid this logging call when running mochitests to fix an intermittent orange. r=tbsaunde draft
authorBlake Kaplan <mrbkap@gmail.com>
Wed, 19 Oct 2016 17:44:04 -0700
changeset 430439 4f5d8f104f103628b701fa349bb1ed371fb42008
parent 430427 d65a9494010ec7dd1ac87f63a844d7fca0270293
child 535211 d6c29f9e7026c1ed84f7dc173faf587f781e5201
push id33833
push userbmo:mrbkap@mozilla.com
push dateThu, 27 Oct 2016 20:52:27 +0000
reviewerstbsaunde
bugs1307645
milestone52.0a1
Bug 1307645 - Avoid this logging call when running mochitests to fix an intermittent orange. r=tbsaunde MozReview-Commit-ID: BWdrTM2JdZs
accessible/tests/browser/e10s/events.js
--- a/accessible/tests/browser/e10s/events.js
+++ b/accessible/tests/browser/e10s/events.js
@@ -63,17 +63,21 @@ function waitForEvent(eventType, expecte
   return new Promise(resolve => {
     let eventObserver = {
       observe(subject, topic, data) {
         if (topic !== 'accessible-event') {
           return;
         }
 
         let event = subject.QueryInterface(nsIAccessibleEvent);
-        Logger.log(eventToString(event));
+        if (Logger.enabled) {
+          // Avoid calling eventToString if the logger isn't enabled in order
+          // to avoid an intermittent crash (bug 1307645).
+          Logger.log(eventToString(event));
+        }
 
         // If event type does not match expected type, skip the event.
         if (event.eventType !== eventType) {
           return;
         }
 
         let acc = event.accessible;
         let id = getAccessibleDOMNodeID(acc);