Bug 1310140. Part 11 - make StateObject::HandleVideoSuspendTimeout() pure virtual for all sub-classes override it. draft
authorJW Wang <jwwang@mozilla.com>
Tue, 18 Oct 2016 13:58:34 +0800
changeset 426836 9fc043196994bda7aff42381b09ec0ca66477779
parent 426835 b009cd1db3b214b05e09b8ba2c82df9153bc0554
child 426837 cebaece8441a52370b2954898dfe4c852832edd7
push id32814
push userjwwang@mozilla.com
push dateWed, 19 Oct 2016 06:32:41 +0000
bugs1310140
milestone52.0a1
Bug 1310140. Part 11 - make StateObject::HandleVideoSuspendTimeout() pure virtual for all sub-classes override it. MozReview-Commit-ID: 2uZHm3NZIFV
dom/media/MediaDecoderStateMachine.cpp
--- a/dom/media/MediaDecoderStateMachine.cpp
+++ b/dom/media/MediaDecoderStateMachine.cpp
@@ -210,22 +210,17 @@ public:
   virtual bool HandleWaitingForData() { return false; }
 
   virtual RefPtr<MediaDecoder::SeekPromise> HandleSeek(SeekTarget aTarget) = 0;
 
   virtual bool HandleAudioCaptured() { return false; }
 
   virtual RefPtr<ShutdownPromise> HandleShutdown();
 
-  virtual void HandleVideoSuspendTimeout()
-  {
-    mMaster->mVideoDecodeSuspended = true;
-    mMaster->mOnPlaybackEvent.Notify(MediaEventType::EnterVideoSuspend);
-    Reader()->SetVideoBlankDecode(true);
-  }
+  virtual void HandleVideoSuspendTimeout() = 0;
 
   virtual void DumpDebugInfo() {}
 
 protected:
   using Master = MediaDecoderStateMachine;
   explicit StateObject(Master* aPtr) : mMaster(aPtr) {}
   TaskQueue* OwnerThread() const { return mMaster->mTaskQueue; }
   MediaResource* Resource() const { return mMaster->mResource; }