Bug 1306366 - mach eslint no longer accepts --no-ignore as a parameter. r?ahal draft
authorPhilipp Kewisch <mozilla@kewis.ch>
Fri, 14 Oct 2016 14:20:23 +0200
changeset 425291 372ea55de65c9ed7d57989b344f0d636a50b16ea
parent 425289 b0f7b8ce6626cb4a70211743793a7dfaae38959b
child 533885 67480ffeb894d830d86e12d534a160b39c897791
push id32389
push usermozilla@kewis.ch
push dateFri, 14 Oct 2016 12:28:44 +0000
reviewersahal
bugs1306366
milestone52.0a1
Bug 1306366 - mach eslint no longer accepts --no-ignore as a parameter. r?ahal MozReview-Commit-ID: LpT0Qlv6vsE
tools/lint/mach_commands.py
--- a/tools/lint/mach_commands.py
+++ b/tools/lint/mach_commands.py
@@ -50,11 +50,12 @@ class MachCommands(MachCommandBase):
     @CommandArgument('-s', '--setup', default=False, action='store_true',
                      help='Configure eslint for optimal development.')
     @CommandArgument('-b', '--binary', default=None,
                      help='Path to eslint binary.')
     @CommandArgument('--fix', default=False, action='store_true',
                      help='Request that eslint automatically fix errors, where possible.')
     @CommandArgument('extra_args', nargs=argparse.REMAINDER,
                      help='Extra args that will be forwarded to eslint.')
-    def eslint(self, paths, **kwargs):
+    def eslint(self, paths, extra_args=[], **kwargs):
         self._mach_context.commands.dispatch('lint', self._mach_context,
-                                             linters=['eslint'], paths=paths, **kwargs)
+                                             linters=['eslint'], paths=paths,
+                                             argv=extra_args, **kwargs)