Bug 1266134 - Fix responsive design possible leak on shutdown. r=jryans draft
authorAlexandre Poirot <poirot.alex@gmail.com>
Thu, 15 Sep 2016 09:57:46 -0700
changeset 429855 9f905d7105530763789848549b4f9a044c98c203
parent 429854 c5c08a377540685acce9c35d0ce462c65af3a819
child 429856 4ec0289f2d1c72d1dee66d1422fe5aeb5ad7ccba
push id33684
push userbmo:poirot.alex@gmail.com
push dateWed, 26 Oct 2016 19:22:05 +0000
reviewersjryans
bugs1266134
milestone52.0a1
Bug 1266134 - Fix responsive design possible leak on shutdown. r=jryans MozReview-Commit-ID: 3DteAYhBDNi
devtools/client/responsivedesign/resize-commands.js
--- a/devtools/client/responsivedesign/resize-commands.js
+++ b/devtools/client/responsivedesign/resize-commands.js
@@ -54,20 +54,19 @@ exports.items = [
       },
       onChange: function (aTarget, aChangeHandler) {
         if (aTarget.tab) {
           ResponsiveUIManager.on("on", aChangeHandler);
           ResponsiveUIManager.on("off", aChangeHandler);
         }
       },
       offChange: function (aTarget, aChangeHandler) {
-        if (aTarget.tab) {
-          ResponsiveUIManager.off("on", aChangeHandler);
-          ResponsiveUIManager.off("off", aChangeHandler);
-        }
+        // Do not check for target.tab as it may already be null during destroy
+        ResponsiveUIManager.off("on", aChangeHandler);
+        ResponsiveUIManager.off("off", aChangeHandler);
       },
     },
     exec: gcli_cmd_resize
   },
   {
     item: "command",
     runAt: "client",
     name: "resize to",