Bug 1309015 - Move MOZ_STUB_INSTALLER to Python configure. draft
authorChris Manchester <cmanchester@mozilla.com>
Mon, 10 Oct 2016 21:59:25 -0700
changeset 423386 c80d7431ecaa227f924f241a6a5c639c8e588eb8
parent 423385 50e791761d3e70d9dfac341ba8c0aa546daac7a6
child 423387 a36ede05361a4672f90bdc616d480c860d4fa9c8
push id31893
push usercmanchester@mozilla.com
push dateTue, 11 Oct 2016 04:59:51 +0000
bugs1309015
milestone52.0a1
Bug 1309015 - Move MOZ_STUB_INSTALLER to Python configure. MozReview-Commit-ID: ALjkPPapBsS
browser/confvars.sh
browser/moz.configure
old-configure.in
--- a/browser/confvars.sh
+++ b/browser/confvars.sh
@@ -8,31 +8,16 @@ MOZ_APP_VENDOR=Mozilla
 MOZ_UPDATER=1
 MOZ_PHOENIX=1
 
 if test "$OS_ARCH" = "WINNT" -o \
         "$OS_ARCH" = "Linux"; then
   MOZ_BUNDLED_FONTS=1
 fi
 
-if test "$OS_ARCH" = "WINNT"; then
-  if ! test "$HAVE_64BIT_BUILD"; then
-    if test "$MOZ_UPDATE_CHANNEL" = "nightly" -o \
-            "$MOZ_UPDATE_CHANNEL" = "aurora" -o \
-            "$MOZ_UPDATE_CHANNEL" = "beta" -o \
-            "$MOZ_UPDATE_CHANNEL" = "beta-dev" -o \
-            "$MOZ_UPDATE_CHANNEL" = "release" -o \
-            "$MOZ_UPDATE_CHANNEL" = "release-dev"; then
-      if ! test "$MOZ_DEBUG"; then
-        MOZ_STUB_INSTALLER=1
-      fi
-    fi
-  fi
-fi
-
 # Enable building ./signmar and running libmar signature tests
 MOZ_ENABLE_SIGNMAR=1
 
 MOZ_APP_VERSION=$FIREFOX_VERSION
 MOZ_APP_VERSION_DISPLAY=$FIREFOX_VERSION_DISPLAY
 MOZ_EXTENSIONS_DEFAULT=" gio"
 # MOZ_APP_DISPLAYNAME will be set by branding/configure.sh
 # MOZ_BRANDING_DIRECTORY is the default branding directory used when none is
--- a/browser/moz.configure
+++ b/browser/moz.configure
@@ -14,9 +14,20 @@ imply_option('MOZ_SERVICES_CLOUDSYNC', T
 @depends(target)
 def maintenance_service(target):
     if target.os == 'WINNT':
         return True
 
 set_config('MOZ_MAINTENANCE_SERVICE', maintenance_service)
 set_define('MOZ_MAINTENANCE_SERVICE', maintenance_service)
 
+@depends(target, have_64_bit, '--enable-debug', update_channel)
+def stub_installer(target, have_64_bit, debug, update_channel):
+    if all([target.os == 'WINNT',
+            not have_64_bit,
+            not debug,
+            update_channel in ('nightly', 'aurora', 'beta',
+                               'beta-dev', 'release', 'release-dev')]):
+        return True
+
+set_config('MOZ_STUB_INSTALLER', stub_installer)
+
 include('../toolkit/moz.configure')
--- a/old-configure.in
+++ b/old-configure.in
@@ -5451,17 +5451,16 @@ AC_SUBST(MOZ_FEEDS)
 
 AC_SUBST(MOZ_UNIVERSALCHARDET)
 AC_SUBST(ACCESSIBILITY)
 AC_SUBST(MOZ_SPELLCHECK)
 AC_SUBST(MOZ_ANDROID_ANR_REPORTER)
 AC_SUBST(MOZ_CRASHREPORTER)
 AC_SUBST(MOZ_CRASHREPORTER_INJECTOR)
 AC_SUBST(MOZ_CRASHREPORTER_UPLOAD_FULL_SYMBOLS)
-AC_SUBST(MOZ_STUB_INSTALLER)
 AC_SUBST(MOZ_VERIFY_MAR_SIGNATURE)
 AC_SUBST(MOZ_ENABLE_SIGNMAR)
 AC_SUBST(MOZ_UPDATER)
 
 AC_SUBST(MOZ_ANGLE_RENDERER)
 AC_SUBST(MOZ_D3D_CPU_SUFFIX)
 AC_SUBST(MOZ_HAS_WINSDK_WITH_D3D)
 AC_SUBST(MOZ_D3DCOMPILER_VISTA_DLL)