Bug 1309015 - Move MOZ_MAINTENANCE_SERVICE to Python configure. draft
authorChris Manchester <cmanchester@mozilla.com>
Mon, 10 Oct 2016 21:59:25 -0700
changeset 423385 50e791761d3e70d9dfac341ba8c0aa546daac7a6
parent 423199 7be6b348c431d69f96f0765af3a0c0a0fe56d4bf
child 423386 c80d7431ecaa227f924f241a6a5c639c8e588eb8
push id31893
push usercmanchester@mozilla.com
push dateTue, 11 Oct 2016 04:59:51 +0000
bugs1309015
milestone52.0a1
Bug 1309015 - Move MOZ_MAINTENANCE_SERVICE to Python configure. This was force-enabled on Windows, and disallowed anywhere else by old-configure, so the option was removed and only the forced value is reflected in Python configure. MozReview-Commit-ID: BT7vgK85qKP
browser/confvars.sh
browser/moz.configure
build/moz.configure/old.configure
old-configure.in
--- a/browser/confvars.sh
+++ b/browser/confvars.sh
@@ -9,17 +9,16 @@ MOZ_UPDATER=1
 MOZ_PHOENIX=1
 
 if test "$OS_ARCH" = "WINNT" -o \
         "$OS_ARCH" = "Linux"; then
   MOZ_BUNDLED_FONTS=1
 fi
 
 if test "$OS_ARCH" = "WINNT"; then
-  MOZ_MAINTENANCE_SERVICE=1
   if ! test "$HAVE_64BIT_BUILD"; then
     if test "$MOZ_UPDATE_CHANNEL" = "nightly" -o \
             "$MOZ_UPDATE_CHANNEL" = "aurora" -o \
             "$MOZ_UPDATE_CHANNEL" = "beta" -o \
             "$MOZ_UPDATE_CHANNEL" = "beta-dev" -o \
             "$MOZ_UPDATE_CHANNEL" = "release" -o \
             "$MOZ_UPDATE_CHANNEL" = "release-dev"; then
       if ! test "$MOZ_DEBUG"; then
--- a/browser/moz.configure
+++ b/browser/moz.configure
@@ -4,9 +4,19 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 imply_option('MOZ_PLACES', True)
 imply_option('MOZ_SERVICES_HEALTHREPORT', True)
 imply_option('MOZ_SERVICES_SYNC', True)
 imply_option('MOZ_SERVICES_CLOUDSYNC', True)
 
+# Build Maintenance Service on Windows
+# ==============================================================
+@depends(target)
+def maintenance_service(target):
+    if target.os == 'WINNT':
+        return True
+
+set_config('MOZ_MAINTENANCE_SERVICE', maintenance_service)
+set_define('MOZ_MAINTENANCE_SERVICE', maintenance_service)
+
 include('../toolkit/moz.configure')
--- a/build/moz.configure/old.configure
+++ b/build/moz.configure/old.configure
@@ -189,17 +189,16 @@ def old_configure_options(*options):
     '--enable-install-strip',
     '--enable-ion',
     '--enable-ios-target',
     '--enable-jitspew',
     '--enable-libjpeg-turbo',
     '--enable-libproxy',
     '--enable-llvm-hacks',
     '--enable-logrefcnt',
-    '--enable-maintenance-service',
     '--enable-memory-sanitizer',
     '--enable-mobile-optimize',
     '--enable-mozril-geoloc',
     '--enable-necko-wifi',
     '--enable-negotiateauth',
     '--enable-nfc',
     '--enable-nspr-build',
     '--enable-official-branding',
--- a/old-configure.in
+++ b/old-configure.in
@@ -3890,33 +3890,16 @@ if test -n "$MOZ_TREE_FREETYPE"; then
    AC_DEFINE(HAVE_FT_LOAD_SFNT_TABLE)
    AC_SUBST_LIST(CAIRO_FT_CFLAGS)
 fi
 
 AC_CHECK_PROGS(WGET, wget, "")
 AC_SUBST(WGET)
 
 dnl ========================================================
-dnl Maintenance Service
-dnl ========================================================
-
-MOZ_ARG_ENABLE_BOOL(maintenance-service,
-[  --enable-maintenance-service       Enable building of maintenanceservice],
-    MOZ_MAINTENANCE_SERVICE=1,
-    MOZ_MAINTENANCE_SERVICE= )
-
-if test -n "$MOZ_MAINTENANCE_SERVICE"; then
-  if test "$OS_ARCH" = "WINNT"; then
-    AC_DEFINE(MOZ_MAINTENANCE_SERVICE)
-  else
-    AC_MSG_ERROR([Can only build with --enable-maintenance-service with a Windows target])
-  fi
-fi
-
-dnl ========================================================
 dnl Bundled fonts on desktop platforms
 dnl ========================================================
 
 MOZ_ARG_ENABLE_BOOL(bundled-fonts,
 [  --enable-bundled-fonts  Enable support for bundled fonts on desktop platforms],
     MOZ_BUNDLED_FONTS=1,
     MOZ_BUNDLED_FONTS=)
 
@@ -5468,17 +5451,16 @@ AC_SUBST(MOZ_FEEDS)
 
 AC_SUBST(MOZ_UNIVERSALCHARDET)
 AC_SUBST(ACCESSIBILITY)
 AC_SUBST(MOZ_SPELLCHECK)
 AC_SUBST(MOZ_ANDROID_ANR_REPORTER)
 AC_SUBST(MOZ_CRASHREPORTER)
 AC_SUBST(MOZ_CRASHREPORTER_INJECTOR)
 AC_SUBST(MOZ_CRASHREPORTER_UPLOAD_FULL_SYMBOLS)
-AC_SUBST(MOZ_MAINTENANCE_SERVICE)
 AC_SUBST(MOZ_STUB_INSTALLER)
 AC_SUBST(MOZ_VERIFY_MAR_SIGNATURE)
 AC_SUBST(MOZ_ENABLE_SIGNMAR)
 AC_SUBST(MOZ_UPDATER)
 
 AC_SUBST(MOZ_ANGLE_RENDERER)
 AC_SUBST(MOZ_D3D_CPU_SUFFIX)
 AC_SUBST(MOZ_HAS_WINSDK_WITH_D3D)