Bug 1308076 - Consistently put expected value where it's expected in EXPECT_EQ() in Pssh Parser gtest. r=jwwang draft
authorChris Pearce <cpearce@mozilla.com>
Fri, 07 Oct 2016 21:17:42 +1300
changeset 423465 6323953291778e54221cab80fadc86dd2203f4e8
parent 423464 9cadc674906b3a9e9004b5edc3034ee89867f805
child 423466 6427f09f963e706c689baad6ca08abc52ce1f663
push id31912
push userbmo:cpearce@mozilla.com
push dateTue, 11 Oct 2016 08:02:34 +0000
reviewersjwwang
bugs1308076
milestone52.0a1
Bug 1308076 - Consistently put expected value where it's expected in EXPECT_EQ() in Pssh Parser gtest. r=jwwang The expected value comes first in the EXPECT_EQ gtest macro. So reorder our calls to this macro in the Pssh Parser gtests to match that. This makes it easier to read what's the expected value when the test fails. MozReview-Commit-ID: LJ4ND2gRPi4
media/gmp-clearkey/0.1/gtest/TestClearKeyUtils.cpp
--- a/media/gmp-clearkey/0.1/gtest/TestClearKeyUtils.cpp
+++ b/media/gmp-clearkey/0.1/gtest/TestClearKeyUtils.cpp
@@ -193,44 +193,44 @@ const uint8_t g2xGoogleWPTCencInitData[]
   0x00, 0x00, 0x00, 0x00                           // datasize
 };
 
 TEST(ClearKey, ParseCencInitData) {
   std::vector<std::vector<uint8_t>> keyIds;
   bool rv;
 
   rv = ParseCENCInitData(gGoogleWPTCencInitData, MOZ_ARRAY_LENGTH(gGoogleWPTCencInitData), keyIds);
-  EXPECT_EQ(true, rv);
-  EXPECT_EQ(keyIds.size(), 1u);
-  EXPECT_EQ(keyIds[0].size(), 16u);
-  EXPECT_EQ(memcmp(&keyIds[0].front(), &gGoogleWPTCencInitData[32], 16), 0);
+  EXPECT_TRUE(rv);
+  EXPECT_EQ(1u, keyIds.size());
+  EXPECT_EQ(16u, keyIds[0].size());
+  EXPECT_EQ(0, memcmp(&keyIds[0].front(), &gGoogleWPTCencInitData[32], 16));
 
   rv = ParseCENCInitData(gW3SpecExampleCencInitData, MOZ_ARRAY_LENGTH(gW3SpecExampleCencInitData), keyIds);
-  EXPECT_EQ(true, rv);
-  EXPECT_EQ(keyIds.size(), 2u);
-  EXPECT_EQ(keyIds[0].size(), 16u);
-  EXPECT_EQ(memcmp(&keyIds[0].front(), &gW3SpecExampleCencInitData[32], 16), 0);
-  EXPECT_EQ(memcmp(&keyIds[1].front(), &gW3SpecExampleCencInitData[48], 16), 0);
+  EXPECT_TRUE(rv);
+  EXPECT_EQ(2u, keyIds.size());
+  EXPECT_EQ(16u, keyIds[0].size());
+  EXPECT_EQ(0, memcmp(&keyIds[0].front(), &gW3SpecExampleCencInitData[32], 16));
+  EXPECT_EQ(0, memcmp(&keyIds[1].front(), &gW3SpecExampleCencInitData[48], 16));
 
   rv = ParseCENCInitData(gOverflowBoxSize, MOZ_ARRAY_LENGTH(gOverflowBoxSize), keyIds);
-  EXPECT_EQ(false, rv);
-  EXPECT_EQ(keyIds.size(), 0u);
+  EXPECT_FALSE(rv);
+  EXPECT_EQ(0u, keyIds.size());
 
   rv = ParseCENCInitData(gTooLargeKeyCountInitData, MOZ_ARRAY_LENGTH(gTooLargeKeyCountInitData), keyIds);
-  EXPECT_EQ(false, rv);
+  EXPECT_FALSE(rv);
   EXPECT_EQ(0u, keyIds.size());
 
   rv = ParseCENCInitData(gNonCencInitData, MOZ_ARRAY_LENGTH(gNonCencInitData), keyIds);
-  EXPECT_EQ(true, rv);
+  EXPECT_TRUE(rv);
   EXPECT_EQ(0u, keyIds.size());
 
   rv = ParseCENCInitData(gNonPSSHBoxZeroSize, MOZ_ARRAY_LENGTH(gNonPSSHBoxZeroSize), keyIds);
-  EXPECT_EQ(false, rv);
-  EXPECT_EQ(keyIds.size(), 0u);
+  EXPECT_FALSE(rv);
+  EXPECT_EQ(0u, keyIds.size());
 
   rv = ParseCENCInitData(g2xGoogleWPTCencInitData, MOZ_ARRAY_LENGTH(g2xGoogleWPTCencInitData), keyIds);
-  EXPECT_EQ(true, rv);
-  EXPECT_EQ(keyIds.size(), 2u);
-  EXPECT_EQ(keyIds[0].size(), 16u);
-  EXPECT_EQ(keyIds[1].size(), 16u);
-  EXPECT_EQ(memcmp(&keyIds[0].front(), &g2xGoogleWPTCencInitData[32], 16), 0);
-  EXPECT_EQ(memcmp(&keyIds[1].front(), &g2xGoogleWPTCencInitData[84], 16), 0);
+  EXPECT_TRUE(rv);
+  EXPECT_EQ(2u, keyIds.size());
+  EXPECT_EQ(16u, keyIds[0].size());
+  EXPECT_EQ(16u, keyIds[1].size());
+  EXPECT_EQ(0, memcmp(&keyIds[0].front(), &g2xGoogleWPTCencInitData[32], 16));
+  EXPECT_EQ(0, memcmp(&keyIds[1].front(), &g2xGoogleWPTCencInitData[84], 16));
 }