Bug 1306608 - Activity Stream: Update top sites padding/margin to match highlights look&feel. r?grisha draft
authorSebastian Kaspari <s.kaspari@gmail.com>
Thu, 06 Oct 2016 15:40:50 +0200
changeset 421663 ee741cd099b6883bc6ef5b47b6c64c095c378dc7
parent 421287 b30134c91cabe8b2926c8d61d6c81e9b5bfdc61f
child 421664 2aa5692607ffc9d7cc1696ea6b0b8930de63172c
push id31558
push users.kaspari@gmail.com
push dateThu, 06 Oct 2016 15:54:11 +0000
reviewersgrisha
bugs1306608
milestone52.0a1
Bug 1306608 - Activity Stream: Update top sites padding/margin to match highlights look&feel. r?grisha MozReview-Commit-ID: KOROFaHZaL3
mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
mobile/android/base/resources/layout/activity_stream_topsites_card.xml
mobile/android/base/resources/layout/activity_stream_topsites_page.xml
--- a/mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
+++ b/mobile/android/base/resources/layout/activity_stream_main_toppanel.xml
@@ -3,17 +3,17 @@
                 xmlns:tools="http://schemas.android.com/tools"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 xmlns:app="http://schemas.android.com/apk/res-auto"
                 android:orientation="vertical">
 
     <android.support.v4.view.ViewPager
         android:layout_width="match_parent"
-        android:layout_height="123dp"
+        android:layout_height="108dp"
         android:id="@+id/topsites_pager"
         android:layout_alignParentTop="true"
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"/>
 
     <org.mozilla.gecko.home.activitystream.topsites.CirclePageIndicator
         android:id="@+id/topsites_indicator"
         android:padding="10dip"
--- a/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
+++ b/mobile/android/base/resources/layout/activity_stream_topsites_card.xml
@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <org.mozilla.gecko.widget.FilledCardView
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
+    xmlns:gecko="http://schemas.android.com/apk/res-auto"
     android:layout_width="wrap_content"
-    android:layout_height="115dp"
-    xmlns:gecko="http://schemas.android.com/apk/res-auto"
-    android:layout_margin="1dp">
-
+    android:layout_height="100dp"
+    android:layout_margin="3dp"
+    gecko:cardPreventCornerOverlap="false">
     <RelativeLayout
         android:layout_width="match_parent"
         android:layout_height="match_parent">
 
         <org.mozilla.gecko.widget.FaviconView
             android:id="@+id/favicon"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
@@ -45,9 +45,9 @@
             android:layout_gravity="right|top"
             android:padding="6dp"
             android:src="@drawable/menu"
             android:layout_alignParentTop="true"
             android:layout_alignParentRight="true"
             android:layout_alignParentEnd="true"/>
 
     </RelativeLayout>
-</org.mozilla.gecko.widget.FilledCardView>
\ No newline at end of file
+</org.mozilla.gecko.widget.FilledCardView>
--- a/mobile/android/base/resources/layout/activity_stream_topsites_page.xml
+++ b/mobile/android/base/resources/layout/activity_stream_topsites_page.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <org.mozilla.gecko.home.activitystream.topsites.TopSitesPage xmlns:android="http://schemas.android.com/apk/res/android"
               android:orientation="vertical"
               android:layout_width="match_parent"
               android:layout_height="match_parent"
-              android:padding="4dp"/>
+              android:paddingLeft="8dp"
+              android:paddingRight="8dp" />