Bug 1307013: Error once number of errors reach threshold. r?gerald draft
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 06 Oct 2016 16:31:35 +1100
changeset 421458 5a3bc09acb8e926436e144ff9ef48a84d79669d6
parent 421258 e8fa13708c070d1fadf488ed9d951464745b4e17
child 421463 5856b4c3304c52787af993be95fbb60652318e4e
child 421836 24b1dcab0d4e6b41aa3c4dff26e45c85e5272b1d
push id31509
push userbmo:jyavenard@mozilla.com
push dateThu, 06 Oct 2016 05:32:29 +0000
reviewersgerald
bugs1307013
milestone52.0a1
Bug 1307013: Error once number of errors reach threshold. r?gerald MozReview-Commit-ID: L6hI7CRSCCF
dom/media/MediaFormatReader.h
--- a/dom/media/MediaFormatReader.h
+++ b/dom/media/MediaFormatReader.h
@@ -323,17 +323,19 @@ private:
     }
 
     uint32_t mNumOfConsecutiveError;
     uint32_t mMaxConsecutiveError;
 
     Maybe<MediaResult> mError;
     bool HasFatalError() const
     {
-      return mError.isSome() && mError.ref() != NS_ERROR_DOM_MEDIA_DECODE_ERR;
+      return mError.isSome() &&
+             (mError.ref() != NS_ERROR_DOM_MEDIA_DECODE_ERR ||
+              mNumOfConsecutiveError > mMaxConsecutiveError);
     }
 
     // If set, all decoded samples prior mTimeThreshold will be dropped.
     // Used for internal seeking when a change of stream is detected or when
     // encountering data discontinuity.
     Maybe<InternalSeekTarget> mTimeThreshold;
     // Time of last sample returned.
     Maybe<media::TimeInterval> mLastSampleTime;